Skip to content

Conversation

@vgvoleg
Copy link
Contributor

@vgvoleg vgvoleg commented Sep 18, 2024

Add an ability to use YDB scan queries via new YDB operator
https://ydb.tech/docs/en/concepts/scan_query


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 18, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@vgvoleg vgvoleg changed the title Add an ability to use scan queries via YDB provider Add an ability to use scan queries via new YDB operator Sep 18, 2024
@vgvoleg vgvoleg marked this pull request as draft September 18, 2024 14:19
@vgvoleg vgvoleg marked this pull request as ready for review September 18, 2024 16:44
@vgvoleg vgvoleg force-pushed the ydb-provider-scan-query-support branch from 4d20c3f to 1973ff0 Compare September 18, 2024 16:49
ashb
ashb previously requested changes Sep 26, 2024
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes changes to the vendored file that are not included in the upstream project https://github.com/ydb-platform/ydb-sqlalchemy/blob/main/ydb_sqlalchemy/dbapi/cursor.py -- we should submit the change there first please, or find a way to make this change that doesn't involve the vendored files diverging from the upstream project in terms of features.

@vgvoleg vgvoleg requested a review from ashb September 29, 2024 13:25
@vgvoleg vgvoleg requested a review from uzhastik October 1, 2024 16:18
@potiuk
Copy link
Member

potiuk commented Oct 2, 2024

This makes changes to the vendored file that are not included in the upstream project https://github.com/ydb-platform/ydb-sqlalchemy/blob/main/ydb_sqlalchemy/dbapi/cursor.py -- we should submit the change there first please, or find a way to make this change that doesn't involve the vendored files diverging from the upstream project in terms of features.

Quite agree with @ashb on that one.

@vgvoleg
Copy link
Contributor Author

vgvoleg commented Oct 3, 2024

This makes changes to the vendored file that are not included in the upstream project https://github.com/ydb-platform/ydb-sqlalchemy/blob/main/ydb_sqlalchemy/dbapi/cursor.py -- we should submit the change there first please, or find a way to make this change that doesn't involve the vendored files diverging from the upstream project in terms of features.

Quite agree with @ashb on that one.

These changes are already on vendor side, I've just updated the version of copied files. We still have no separate package to import directly without any issues, the problem is described here https://github.com/apache/airflow/blob/3bb6d02107493af64c4ed1b5fb4a6b8448c29945/airflow/providers/ydb/hooks/_vendor/readme.md

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. OK then. LGTM.

@potiuk
Copy link
Member

potiuk commented Oct 3, 2024

@ashb -> can you remove the "require changes" please?

@ashb
Copy link
Member

ashb commented Oct 3, 2024

I can't from my phone but please dismiss it if you can

@potiuk potiuk dismissed ashb’s stale review October 4, 2024 01:51

Agreed with Ash

@potiuk potiuk merged commit 3c4fbce into apache:main Oct 4, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 4, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
* Add an ability to use scan queries via YDB provider

* Add YDBScanQueryOperator docs

* Update vendor package of ydb
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Add an ability to use scan queries via YDB provider

* Add YDBScanQueryOperator docs

* Update vendor package of ydb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants