-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add an ability to use scan queries via new YDB operator #42311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
4d20c3f to
1973ff0
Compare
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes changes to the vendored file that are not included in the upstream project https://github.com/ydb-platform/ydb-sqlalchemy/blob/main/ydb_sqlalchemy/dbapi/cursor.py -- we should submit the change there first please, or find a way to make this change that doesn't involve the vendored files diverging from the upstream project in terms of features.
Quite agree with @ashb on that one. |
These changes are already on vendor side, I've just updated the version of copied files. We still have no separate package to import directly without any issues, the problem is described here https://github.com/apache/airflow/blob/3bb6d02107493af64c4ed1b5fb4a6b8448c29945/airflow/providers/ydb/hooks/_vendor/readme.md |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. OK then. LGTM.
|
@ashb -> can you remove the "require changes" please? |
|
I can't from my phone but please dismiss it if you can |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Add an ability to use scan queries via YDB provider * Add YDBScanQueryOperator docs * Update vendor package of ydb
* Add an ability to use scan queries via YDB provider * Add YDBScanQueryOperator docs * Update vendor package of ydb
Add an ability to use YDB scan queries via new YDB operator
https://ydb.tech/docs/en/concepts/scan_query
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.