-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add new Google Search 360 Reporting Operators #42255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Google Search 360 Reporting Operators #42255
Conversation
Please insert this information at the top of the google provider changelog |
e3cd2e4 to
0c9ab81
Compare
Remove the decommissioned operators # Conflicts: # tests/providers/google/marketing_platform/operators/test_search_ads.py
The twisted/incremental#106 issue has been addressed in 24.7.2 so we are removing the limit - just in case we also exclude the buggy versions, even if they are yanked.
25eeb86 to
2908bdb
Compare
Remove the decommissioned operators
2908bdb to
040431b
Compare
|
@eladkal I add a warning section to the CHANGELOG. I create a new section for the next minor version (10.23.0) and put the message as a warning. I also saw some other kind of sections like |
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
* Implement new Google Search 360 operators Remove the decommissioned operators Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
This PR will introduce new Operators for Google Search 360 service and remove the already failing operators.
Here is a bit of an explanation for clearer understanding;
The previous Search Ads 360 Reporting API (which is currently in use in google-provider) was already decommissioned on June 30, 2024 (see deatils). All new reporting development should use the new Search Ads 360 Reporting API.
Currently, the Reporting operators, sensors and hooks are failing due to the decommission. The new API is not a replacement for the old one, it has a different approach and APIs. Therefore, we needed to implement new operators and remove the old ones. This PR does NOT break any working DAG, because it replaces not working functionality with the new one.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.