Skip to content

Conversation

@molcay
Copy link
Contributor

@molcay molcay commented Sep 16, 2024

This PR will introduce new Operators for Google Search 360 service and remove the already failing operators.
Here is a bit of an explanation for clearer understanding;

The previous Search Ads 360 Reporting API (which is currently in use in google-provider) was already decommissioned on June 30, 2024 (see deatils). All new reporting development should use the new Search Ads 360 Reporting API.
Currently, the Reporting operators, sensors and hooks are failing due to the decommission. The new API is not a replacement for the old one, it has a different approach and APIs. Therefore, we needed to implement new operators and remove the old ones. This PR does NOT break any working DAG, because it replaces not working functionality with the new one.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal
Copy link
Contributor

eladkal commented Sep 16, 2024

The previous Search Ads 360 Reporting API (which is currently in use in google-provider) was already decommissioned on June 30, 2024 (see deatils). All new reporting development should use the new Search Ads 360 Reporting API. Currently, the Reporting operators, sensors and hooks are failing due to the decommission. The new API is not a replacement for the old one, it has a different approach and APIs. Therefore, we needed to implement new operators and remove the old ones. This PR does NOT break any working DAG, because it replaces not working functionality with the new one.

Please insert this information at the top of the google provider changelog
I will pick this note during release and assign this to the right place in the log.

@molcay molcay force-pushed the feat/new-google-search-ads-reporting-api-operators branch from e3cd2e4 to 0c9ab81 Compare September 17, 2024 08:26
molcay and others added 2 commits September 17, 2024 08:29
Remove the decommissioned operators

# Conflicts:
#	tests/providers/google/marketing_platform/operators/test_search_ads.py
The twisted/incremental#106 issue has
been addressed in 24.7.2 so we are removing the limit - just in
case we also exclude the buggy versions, even if they are yanked.
@molcay molcay force-pushed the feat/new-google-search-ads-reporting-api-operators branch 2 times, most recently from 25eeb86 to 2908bdb Compare September 17, 2024 08:54
Remove the decommissioned operators
@molcay molcay force-pushed the feat/new-google-search-ads-reporting-api-operators branch from 2908bdb to 040431b Compare September 17, 2024 09:22
@molcay
Copy link
Contributor Author

molcay commented Sep 17, 2024

@eladkal I add a warning section to the CHANGELOG. I create a new section for the next minor version (10.23.0) and put the message as a warning.

I also saw some other kind of sections like Breaking Changes. Do I need to do something like this? or Is the current version enough? WDYT?

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
@molcay molcay requested a review from eladkal September 18, 2024 09:02
@eladkal eladkal merged commit 5679265 into apache:main Sep 19, 2024
@molcay molcay deleted the feat/new-google-search-ads-reporting-api-operators branch September 19, 2024 07:58
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
* Implement new Google Search 360 operators
Remove the decommissioned operators

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants