Skip to content

Conversation

@Mayuresh16
Copy link
Contributor

@Mayuresh16 Mayuresh16 commented Sep 1, 2024

If the destination path is not specified, it defaults to an empty string. As a result, replacing base_path with an empty string is ineffective, causing the destination to retain the "/" prefix, if it has.

closes: #41763
related: #41763

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Sep 1, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 1, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Mayuresh16 Mayuresh16 changed the title [Fix #41763]: Redundant forward slash in SFTPToGCSOperator when destination [Fix #41763]: Redundant forward slash in SFTPToGCSOperator when destination_path is not specified or have default value Sep 1, 2024
@Mayuresh16
Copy link
Contributor Author

@potiuk @romsharon98 @moiseenkov Please merge the code if it looks good to you.

@potiuk potiuk merged commit 7f9f923 into apache:main Sep 2, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 2, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant slash in GCS object URI if wildcard in source_path and no destination_path given in SFTPToGCSOperator

4 participants