pass location correctly to is_dataflow_job_running #41692
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_job_dataflow_runningfunction (https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/hooks/dataflow.py#L1047C9-L1047C32) is called omittinglocationargument from multiple places (see changes), thus, always the default value ofDEFAULT_DATAFLOW_LOCATION = us-central1is used.This causes issues with
BeamRunJavaPipelineOperator. When a job status is set to success/failure dataflow API is called usinglocations/us-central1even when the operator is configured with another region (for exampleeurope-west1), resulting in the job not being found:^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.