Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix log for notifier(instance) without __name__ #41591

Merged
merged 9 commits into from
Aug 23, 2024
Merged

fix log for notifier(instance) without __name__ #41591

merged 9 commits into from
Aug 23, 2024

Conversation

obarisk
Copy link
Contributor

@obarisk obarisk commented Aug 19, 2024

fix #41563

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@obarisk obarisk requested review from kaxil, XD-DENG and ashb as code owners August 19, 2024 15:16
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Aug 19, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@obarisk obarisk mentioned this pull request Aug 19, 2024
Closed
2 tasks
@eladkal eladkal requested a review from romsharon98 August 20, 2024 06:33
@obarisk obarisk requested review from josix and uranusjr August 21, 2024 05:00
@uranusjr
Copy link
Member

Please consider setting up pre-commit to run linters locally before pushing. The code format needs some work.

Search in contributing-docs to find relevant information on how to setup and run pre-commit.

josix
josix approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@josix josix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learn about contextlib.suppress, thanks @uranusjr

@uranusjr
Pass in entire callback object as fallback
9287c02 
Logging can convert an arbitrary object into a string by itself, so we
don't need to call str() eagerly. This can be a bit faster, and more
importantly, preserve as much context as possible for the logging stack
to extract if needed.
@potiuk potiuk added this to the Airflow 2.10.1 milestone Aug 22, 2024
@potiuk
Copy link
Member

potiuk commented Aug 22, 2024 •
edited
Loading

Once the tests are fixed and we merge it - can you please back-port it to as v2-10-test PR @obarisk ?

@uranusjr uranusjr merged commit 0cd4686 into apache:main Aug 23, 2024
50 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Aug 23, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@obarisk obarisk mentioned this pull request Aug 23, 2024
Closed
obarisk added a commit to obarisk/airflow that referenced this pull request Aug 23, 2024
@obarisk @royzhong7070 @uranusjr
fix log for notifier(instance) without __name__ (apache#41591)
f5a696e 
Co-authored-by: obarisk <obarisk@yiyixiu.idv.tw>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
potiuk pushed a commit that referenced this pull request Aug 23, 2024
@obarisk @royzhong7070 @uranusjr
fix log for notifier(instance) without __name__ (#41591) (#41699)
31c20f5 
Co-authored-by: obarisk <obarisk@yiyixiu.idv.tw>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Aug 30, 2024
utkarsharma2 pushed a commit that referenced this pull request Sep 2, 2024
@obarisk @royzhong7070
@uranusjr @utkarsharma2
fix log for notifier(instance) without __name__ (#41591) (#41699)
9deba7b 
Co-authored-by: obarisk <obarisk@yiyixiu.idv.tw>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@obarisk obarisk mentioned this pull request Sep 2, 2024
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josix josix josix approved these changes

@ephraimbuddy ephraimbuddy ephraimbuddy approved these changes

@uranusjr uranusjr uranusjr approved these changes

@potiuk potiuk potiuk approved these changes

@kaxil kaxil Awaiting requested review from kaxil

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@romsharon98 romsharon98 Awaiting requested review from romsharon98

Assignees
No one assigned
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.10.1
Development

Successfully merging this pull request may close these issues.

callback without __name__ are not allowed when taskinstance executing
7 participants
@obarisk @uranusjr @potiuk @ephraimbuddy @josix @utkarsharma2 @royzhong7070