Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change regular expression to exclude double quote and newline #39991

Merged

Conversation

kylase
Copy link
Contributor

@kylase kylase commented Jun 1, 2024

This change tackles a change in Cloud Composer's default storage mechanism for logs as documented in the release notes on March 26, 2024 and May 11, 2024. This causes issue for Beam operator which uses regular expression to identify the Dataflow Job ID from the logs.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

This change tackles a change in Cloud Composer's default storage mechanism for logs as documented in the release notes on [March 26, 2024](https://cloud.google.com/composer/docs/release-notes#March_26_2024) and [May 11, 2024](https://cloud.google.com/composer/docs/release-notes#May_11_2024). This causes issue for Beam operator which uses regular expression to identify the Dataflow Job ID from the logs.
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 1, 2024
Copy link

boring-cyborg bot commented Jun 1, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk requested a review from Lee-W June 1, 2024 09:59
@potiuk potiuk merged commit ce5cd52 into apache:main Jun 1, 2024
49 checks passed
Copy link

boring-cyborg bot commented Jun 1, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@kylase kylase deleted the fix/dataflow-log-parsing-for-job-id branch June 1, 2024 11:26
fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
…#39991)

This change tackles a change in Cloud Composer's default storage mechanism for logs as documented in the release notes on [March 26, 2024](https://cloud.google.com/composer/docs/release-notes#March_26_2024) and [May 11, 2024](https://cloud.google.com/composer/docs/release-notes#May_11_2024). This causes issue for Beam operator which uses regular expression to identify the Dataflow Job ID from the logs.

Co-authored-by: Yuan Chuan Kee <1683885+kylase@users.noreply.github.com>
jannisko pushed a commit to jannisko/airflow that referenced this pull request Jun 15, 2024
…#39991)

This change tackles a change in Cloud Composer's default storage mechanism for logs as documented in the release notes on [March 26, 2024](https://cloud.google.com/composer/docs/release-notes#March_26_2024) and [May 11, 2024](https://cloud.google.com/composer/docs/release-notes#May_11_2024). This causes issue for Beam operator which uses regular expression to identify the Dataflow Job ID from the logs.

Co-authored-by: Yuan Chuan Kee <1683885+kylase@users.noreply.github.com>
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…#39991)

This change tackles a change in Cloud Composer's default storage mechanism for logs as documented in the release notes on [March 26, 2024](https://cloud.google.com/composer/docs/release-notes#March_26_2024) and [May 11, 2024](https://cloud.google.com/composer/docs/release-notes#May_11_2024). This causes issue for Beam operator which uses regular expression to identify the Dataflow Job ID from the logs.

Co-authored-by: Yuan Chuan Kee <1683885+kylase@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants