-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add possibility to override the conn type for Druid #39897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Minor fix, which allows to use the schema which are specified in theschema rather than `http` as default. In the same time it doesn't changethe logic as any conn_type can be selected. Intuitevely it's expectedthat anything specified in `schema` field will actually take precedencein the building the desired url.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
similar issue #27581 |
dirrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Can you add the test case for the same?
|
Hi, can you please validate it, I'd like to remove the step from building docker image, which replace the upstream file with the fixed one. Thank you |
| if self.conn.schema: | ||
| conn_type = self.conn.schema | ||
| else: | ||
| conn_type = self.conn.conn_type or "http" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we define "http" as a constant that denoted the default connection type?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
hi, can we reopen it, ready to fix it. thx |
Minor fix, which allows to use the schema which are specified in theschema rather than
httpas default. In the same time it doesn't changethe logic as any conn_type can be selected. Intuitevely it's expectedthat anything specified inschemafield will actually take precedencein the building the desired url.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.