Fix lazy loading of ObjectStoragePath fs backends #37559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new structure introduces eager loading, which we don't want. This re-instates lazy loading at the expense of that storage_options might not be fully parsed.
Contributor
Author
|
@ap-- could you take a look if this makes sense? particularly the |
Contributor
|
This fails du to an import when the path needs to be parsed. I will open a new issue in universal_pathlib to see how long this could be delayed. |
Contributor
|
I see a few tests are failing. Closing and reopening to return them. |
Contributor
Author
|
closing as this will be solved differently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new structure introduces eager loading,
which we don't want. This re-instates lazy loading at the expense of that storage_options might not be fully parsed.
@potiuk @ap-- @Taragolis
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.