Allow to skip test_should_be_importable if optional dependency not installed
#37558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Taragolis
force-pushed
the
allow-to-skip-validate-examples
branch
from
50b5bc8 to
49e1f4d
Compare
Taragolis
commented
Feb 20, 2024
Taragolis
added
changelog:skip
bolkedebruin
requested changes
Feb 20, 2024
| OPTIONAL_PROVIDERS_DEPENDENCIES: dict[str, dict[str, str | None]] = { | ||
| # Regression of https://github.com/apache/airflow/pull/37524 | ||
| # It loads the module now eagerly instead of lazily | ||
| "tests/system/providers/common/io/example_file_transfer_local_to_s3.py": {"s3fs": None} |
Contributor
There was a problem hiding this comment.
Let's no do this. This one hides the issue
Contributor
Author
There was a problem hiding this comment.
I'm think it depend on how does it long takes to fix it.
If we think that it could be fixed soon, than we fix it first and after that made appropriate changes
If do not know how long does it take we have a to option
Option 1: Revert #37524, otherwise we would have an error in the other tests
Option 2: Hide issue (merge this PR as is), create a task and remove it during the fixing
WDYT?
Contributor
Author
There was a problem hiding this comment.
Seems like it might be a quick fix
Contributor
Author
There was a problem hiding this comment.
But yeah. This fix either not work well. It fix on one case, but not in the others
Contributor
Author
|
Ok, let close it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.