-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more proper typing to StreamLogWriter
#37347
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
c02d427
to
3b39138
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the test case for where it is breaking?
1be36c9
to
2aba3ee
Compare
I hope this is what you intended, otherwise let me know in more detail what would have to be changed |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
2aba3ee
to
ae92c12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im sorry I took so long to get back to this
@Grub4K are you still working on this PR? |
I am waiting for #37347 (comment) to be resolved. Once it is, i can commit the |
If you believe it's handed then resolve it. |
ae92c12
to
721d7e2
Compare
@Grub4K test is failing. Can you look into it?
|
721d7e2
to
553d7b4
Compare
Sorry for the oversight. I couldn't figure out how to run tests locally with |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
This PR makes the
utils.log.logging_mixin.StreamLogWriter
closer resemble the interface ofsys.stdout
/sys.stderr
by implementing the following attributes properly:encoding
returns"undefined"
mode
returns"w"
name
returns"<logger: {name}>"
write
returnsint
writable
returnsTrue
readable
returnsFalse
seekable
returnsFalse
fileno
throwsio.UnsupportedOperation
If different values are desired for these, feel free to let me know.
closes: #36992
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.