Skip to content

Conversation

@arovira
Copy link
Contributor

@arovira arovira commented Feb 7, 2024

closes: #37220
related: #33162

With this PR, failures on find or rm command on logs folder will be ignored (still will be shown on the container logs)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@arovira arovira requested review from ashb and potiuk as code owners February 7, 2024 12:47
@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes labels Feb 7, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 7, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@arovira arovira requested a review from potiuk February 7, 2024 15:07
@potiuk potiuk merged commit b39a2bf into apache:main Feb 7, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 7, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

potiuk pushed a commit that referenced this pull request Feb 7, 2024
…37222)

* Avoid log-groomer container failures when log persistence is enabled

* Ignore erros on rm file command only

---------

Co-authored-by: Arnau Rovira <arnau.rovira@bitsighttech.com>
(cherry picked from commit b39a2bf)
@eladkal eladkal added this to the Airflow 2.8.2 milestone Feb 8, 2024
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Feb 8, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
…37222)

* Avoid log-groomer container failures when log persistence is enabled

* Ignore erros on rm file command only

---------

Co-authored-by: Arnau Rovira <arnau.rovira@bitsighttech.com>
(cherry picked from commit b39a2bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:production-image Production image improvements and fixes type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

log-groomer container crashing with .Values.logs.persistence enabled

5 participants