Skip to content

Conversation

@danbachar
Copy link

@danbachar danbachar commented Jan 30, 2024

add virtualenv as a requirement

add virtualenv as a requirement
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 30, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@danbachar danbachar mentioned this pull request Jan 30, 2024
2 tasks
.. note::

Successful installation requires a Python 3 environment. Starting with Airflow 2.7.0, Airflow supports Python 3.8, 3.9, 3.10 and 3.11.
Successful installation requires a Python 3 environment, along with virtualenv. Starting with Airflow 2.7.0, Airflow supports Python 3.8, 3.9, 3.10 and 3.11.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily, virtualenv recommended way to install it.

@danbachar
Copy link
Author

danbachar commented Jan 30, 2024 via email

@Taragolis
Copy link
Contributor

Virtual environment it is not a strict requirement it is only highly suggested into the non isolated environment. For example you could easily use Airflow which installed into the userspace into the Docker, that how it installed into the Official Airflow Images.

There is difficult to recognise what is going wrong in your case it could be:

  • Conflicting packages with system packages (if it installed as a root as system package)
  • Conflicting packages into the userspaces
  • Missing [core] load_examples config
  • etc

@potiuk
Copy link
Member

potiuk commented Jan 30, 2024

I think the issue is different. You shoudl add note that some examples might not work if you do not install it with [virtualenv] extra. You do not technically need virtualenv to install airflow, but if you want to look at example dags and get them all working you need to install airflow[virtualenv]. There is a subtle difference between the two

https://airflow.apache.org/docs/apache-airflow/stable/extra-packages-ref.html#core-airflow-extras - airflow has different extras and virtualenv is one of them.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 16, 2024
@github-actions github-actions bot closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:documentation stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants