Fix wrong import for cloud build example #33137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
provider:google
potiuk
added
the
full tests needed
Member
Author
|
Reopened to rebuild for Python 3.11 as well. |
The import of urlparse in cloud build was importing "future" urlparse which is a Python 2 remnant (future library has been used in order to make a bridge between Python 2 and Python 3 and provided Python 3 - compatible implementation of some stdlib calls that could be used in both Puthon 3 and Python 2. Apparently one of our of our dependncies stopped pulling future in Python 3.11 so it started to fail our main with Python 3.11 because the future library is missing there. This PR switches the import to regular urlparse.
potiuk
force-pushed
the
remove-future-import-from-cloud-build-example
branch
from
54a4da0 to
6ff2f13
Compare
Member
Author
|
Also urlsplit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import of urlparse in cloud build was importing "future" urlparse which is a Python 2 remnant (future library has been used in order to make a bridge between Python 2 and Python 3 and provided Python 3 - compatible implementation of some stdlib calls that could be used in both Puthon 3 and Python 2.
Apparently one of our of our dependncies stopped pulling future in Python 3.11 so it started to fail our main with Python 3.11 because the future library is missing there.
This PR switches the import to regular urlparse.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.