Update mypy-boto3-appflow dependency #32930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Just testing if post1 fixes the problem |
potiuk
force-pushed
the
test-post1-fix-of-appflow
branch
from
695686d to
39734f1
Compare
potiuk
changed the title
potiuk
force-pushed
the
test-post1-fix-of-appflow
branch
from
39734f1 to
9374d03
Compare
o-nikolas
approved these changes
Aug 4, 2023
Contributor
|
Changes look good to me, but there are tests failing. I'm going to re-trigger those now, I suspect the failures are spurious. |
Member
|
The 3.11 failures seem to be consistent. |
Member
Author
Yeah. It also happened in main. This was caused by some dependency in 3.11 not pulling Rebasing to apply it to this PR. |
After youtype/mypy_boto3_builder#209 has been fixed and mypy-boto3-appflow released, we can now remove the limit and intrduce lower-bound limit for it.
potiuk
force-pushed
the
test-post1-fix-of-appflow
branch
from
9374d03 to
294a0c4
Compare
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After youtype/mypy_boto3_builder#209
has been fixed and mypy-boto3-appflow released, we can now
remove the limit and intrduce lower-bound limit for it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.