-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Deprecate skip_exit_code in BashOperator
#30734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Apr 19, 2023
uranusjr
reviewed
Apr 19, 2023
hussein-awala
approved these changes
Apr 19, 2023
hussein-awala
requested changes
Apr 19, 2023
hussein-awala
approved these changes
Apr 19, 2023
Member
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Member
|
Should we also add the "Container" logic here to be fully consistent? I believe it should be fully backwards compatible ? |
Member
|
Ah... you just merged it @eladkal while I was writing the comment :) |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 19, 2023
Member
|
Here it is #30739 |
potiuk
added a commit
that referenced
this pull request
Apr 19, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 21, 2023
(cherry picked from commit 9c5c5c2)
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #30733 just for core
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.