Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Apr 19, 2023

same as #30733 just for core


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal eladkal added the type:misc/internal Changelog: Misc changes that should appear in change log label Apr 19, 2023
@eladkal eladkal added this to the Airflow 2.6.1 milestone Apr 19, 2023
@eladkal eladkal requested a review from hussein-awala April 19, 2023 10:16
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@eladkal eladkal merged commit 9c5c5c2 into apache:main Apr 19, 2023
@potiuk
Copy link
Member

potiuk commented Apr 19, 2023

Should we also add the "Container" logic here to be fully consistent? I believe it should be fully backwards compatible ?

@eladkal eladkal deleted the bash branch April 19, 2023 11:52
@potiuk
Copy link
Member

potiuk commented Apr 19, 2023

Ah... you just merged it @eladkal while I was writing the comment :)

@potiuk
Copy link
Member

potiuk commented Apr 19, 2023

Here it is #30739

potiuk added a commit that referenced this pull request Apr 19, 2023
@eladkal eladkal modified the milestones: Airflow 2.6.1, Airflow 2.6.0 Apr 19, 2023
ephraimbuddy pushed a commit that referenced this pull request Apr 21, 2023
ephraimbuddy pushed a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants