-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Deprecate skip_exit_code in DockerOperator and KubernetesPodOperator
#30733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7ce0bd6 to
7942f17
Compare
|
My though exactly that we should do that :) |
|
Another follow up here: #30738 - we missed ExternalPythonOperator when adding the 'skip_on_exit_code` |
|
BTW. I gues we could still add those |
|
@potiuk this one is providers only. I split the PRs one for core and one for providers to avoid issues with milestones |
Ah True. silly me :) |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Should we also add container handling ? Or you want to separate it?
Will do it seperatly |
To be consistent with #30692
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.