Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Apr 19, 2023

To be consistent with #30692


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal eladkal force-pushed the skip branch 2 times, most recently from 7ce0bd6 to 7942f17 Compare April 19, 2023 10:29
@potiuk
Copy link
Member

potiuk commented Apr 19, 2023

My though exactly that we should do that :)

@potiuk
Copy link
Member

potiuk commented Apr 19, 2023

Another follow up here: #30738 - we missed ExternalPythonOperator when adding the 'skip_on_exit_code`

@potiuk potiuk added this to the Airflow 2.6.0 milestone Apr 19, 2023
@potiuk
Copy link
Member

potiuk commented Apr 19, 2023

BTW. I gues we could still add those skip_on_exit_code changes to 2.6.0 ? @ephraimbuddy @jedcunningham - WDYT? Those changes seems pretty safe and possible to cherry-pick

@potiuk potiuk modified the milestones: Airflow 2.6.0, Airflow 2.7.0 Apr 19, 2023
@eladkal
Copy link
Contributor Author

eladkal commented Apr 19, 2023

@potiuk this one is providers only. I split the PRs one for core and one for providers to avoid issues with milestones

@eladkal eladkal removed this from the Airflow 2.7.0 milestone Apr 19, 2023
@potiuk
Copy link
Member

potiuk commented Apr 19, 2023

@potiuk this one is providers only. I split the PRs one for core and one for providers to avoid issues with milestones

Ah True. silly me :)

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Should we also add container handling ? Or you want to separate it?

@eladkal
Copy link
Contributor Author

eladkal commented Apr 19, 2023

NIT: Should we also add container handling ? Or you want to separate it?

Will do it seperatly

@potiuk potiuk merged commit 99a3bf2 into apache:main Apr 19, 2023
@eladkal eladkal deleted the skip branch April 19, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants