Skip to content

Conversation

@yuqian90
Copy link
Contributor

@yuqian90 yuqian90 commented Mar 8, 2023

We often hear these two complaints from users:

  1. Graph View does not make use of the whole screen space. The height is clipped at a fixed value. This is especially bad for large monitors.
  2. Graph jumps around when TaskGroup is expanded or collapsed

This PR fixes both issues.

Here's a gif showing some of the UI interactions after this change. Notice these two changes:

  1. The graph now uses the whole page. It's no longer clipped to a fixed height
  2. The clicked node focuses around the cursor when TaskGroup is expanded or collapsed, instead of jumping around.

mvo2

mvo1

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 8, 2023
@yuqian90 yuqian90 added this to the Airflow 2.5.2 milestone Mar 8, 2023
@yuqian90 yuqian90 changed the title Fix some long know Graph View UI problems Fix some long known Graph View UI problems Mar 8, 2023
@yuqian90 yuqian90 self-assigned this Mar 8, 2023
@bbovenzi
Copy link
Contributor

bbovenzi commented Mar 8, 2023

Looking good. Do you mind running yarn && yarn lint in the airflow/www directory? Static checks aren't happy.

@bbovenzi
Copy link
Contributor

bbovenzi commented Mar 8, 2023

Also, the new graph view doesn't have the first problem. But I'll make sure the second problem is also addressed before 2.6.0 is released.

Qian Yu added 4 commits March 9, 2023 08:01
graph zoom changes

Fix find zoom

Remove unused args

Refactor
@yuqian90
Copy link
Contributor Author

yuqian90 commented Mar 9, 2023

Looking good. Do you mind running yarn && yarn lint in the airflow/www directory? Static checks aren't happy.

Thanks for pointing out. Done. It did uncover an unused variable.

Also, the new graph view doesn't have the first problem. But I'll make sure the second problem is also addressed before 2.6.0 is released.

That sounds great. Is there a place to preview what 2.6.0 graph will look like?

@bbovenzi
Copy link
Contributor

bbovenzi commented Mar 9, 2023

That sounds great. Is there a place to preview what 2.6.0 graph will look like?

Either run airflow locally, or you can see some screenshots/gifs in the PR: #29413

@bbovenzi bbovenzi merged commit ff9cae9 into apache:main Mar 9, 2023
@bbovenzi bbovenzi modified the milestones: Airflow 2.5.2, Airflow 2.5.3 Mar 10, 2023
@bbovenzi
Copy link
Contributor

@yuqian90 wdyt of expand/collapse like this?

Mar-14-2023 23-13-36

@yuqian90
Copy link
Contributor Author

@yuqian90 wdyt of expand/collapse like this?

Mar-14-2023 23-13-36 Mar-14-2023 23-13-36

This looks awesome. Does it scale well with large DAGs? e.g. one that has hundreds of tasks and many TaskGroups?

@bbovenzi
Copy link
Contributor

This looks awesome. Does it scale well with large DAGs? e.g. one that has hundreds of tasks and many TaskGroups?

Working on it! If not, maybe we'll just disable animations if there are 1000+ tasks.

@pierrejeambrun pierrejeambrun added the type:bug-fix Changelog: Bug Fixes label Mar 22, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 23, 2023
* Center clicked node around mouse

graph zoom changes

Fix find zoom

Remove unused args

Refactor

* rebase

* revert redundant change

* Fix unused variable

* pre-commit

---------

Co-authored-by: Qian Yu <qian@hudson-trading.com>
(cherry picked from commit ff9cae9)
pierrejeambrun pushed a commit that referenced this pull request Mar 24, 2023
* Center clicked node around mouse

graph zoom changes

Fix find zoom

Remove unused args

Refactor

* rebase

* revert redundant change

* Fix unused variable

* pre-commit

---------

Co-authored-by: Qian Yu <qian@hudson-trading.com>
(cherry picked from commit ff9cae9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants