Helm deployment fails when postgresql.nameOverride is used #29214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
potiuk
approved these changes
Jan 29, 2023
Member
|
Nit: Should we get a test for it to avoid regression? |
Contributor
Author
|
Makes sense to add unit tests @potiuk |
potiuk
force-pushed
the
issue-22790-nameOverride
branch
from
386bbfa to
5c2c55f
Compare
…flow into issue-22790-nameOverride
amoghrajesh
requested review from
jedcunningham
and removed request for
dstandish
jedcunningham
approved these changes
Jan 30, 2023
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
Looks like static checks are failing. I'd also suggest that you set up the pre-commit hooks, they help catch these issues early 👍.
Contributor
Author
|
@jedcunningham @potiuk made the required changes. Can someone merge it once the CI passes? |
Contributor
Author
|
Just fixed all the test case issues. @potiuk / @jedcunningham can someone merge the PR once the CI passes? |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm property:
nameOverrideis not honoured properly for airflow postgresql charts and the connection string is not formed as expected. Fixes the improper url formation mentioned in: #22790.Testing results:
Without any override and release name being: adesai-airflow, namespace: airflow
postgresql://postgres:postgres@adesai-airflow-postgresql.airflow:5432/postgres?sslmode=disable
With override and same configs as above:
postgresql://postgres:postgres@overrideName:5432/postgres?sslmode=disable
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.