Helm deployment fails when postgresql.nameOverride is used

[evanrosebrook]

Apache Airflow version

2.2.5 (latest released)

What happened

Helm installation fails with the following config:

postgresql:
  enabled: true
  nameOverride: overridename

The problem is manifested in the -airflow-metadata secret where the connection string will be generated without respect to the nameOverride

With the example config the generated string should be:

postgresql://postgres:postgres@myrelease-overridename:5432/postgres?sslmode=disable

but the actual string generated is:
postgresql://postgres:postgres@myrelease-overridename.namespace:5432/postgres?sslmode=disable

What you think should happen instead

Installation should succeed with correctly generated metadata connection string

How to reproduce

To reproduce just set the following in values.yaml and attempt helm install

postgresql:
  enabled: true
  nameOverride: overridename

Operating System

Ubuntu

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

using helm with kind cluster

Anything else

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[potiuk]

I think this is already known and handle in the upcoming version of the chart #22676

[evanrosebrook]

Actually this is a different issue. 22676 deals with nameOverride for the top-level airflow chart.

This issue deals with using nameOverride in the postgres sub-chart. For the postgresql chart nameOverride works fine, however the connection string that gets created in the airflow parent does not use the overriden postgres host when generating the connection string and so the deployment fails.

[evanrosebrook]

This issue can be worked around by setting a value for the metadataConnection.host that matches the postgresql.nameOverride. However, I wouldn't think the chart should remain deployable while specifying only the postgresql nameOverride.

postgresql:
  enabled: true
  nameOverride: {{ .Release.Name }}-someName
data:
  metadataConnection:
    host: someName

[potiuk]

would you like to provide a fix?

[amoghrajesh]

@potiuk @evanrosebrook saw that this issue has been idle for sometime. Can I pick it up?

[potiuk]

sure.

[amoghrajesh]

Thanks @potiuk. I have attached a pull request for this: #29214
cc @evanrosebrook

[eladkal]

resolved in #29214