Skip to content

Add all dependent providers when running selective checks #26736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Sep 28, 2022
Merged

Add all dependent providers when running selective checks #26736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac4aeb5
Add all dependent providers when running selective checks
jedcunningham Sep 27, 2022
274c95c
Fix tests
jedcunningham Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dev/breeze/src/airflow_breeze/utils/selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,12 @@ def add_dependent_providers(
providers: set[str], provider_to_check: str, dependencies: dict[str, dict[str, list[str]]]
):
for provider, provider_info in dependencies.items():
# Providers that use this provider
if provider_to_check in provider_info['cross-providers-deps']:
providers.add(provider)
# and providers we use directly
for dep_name in dependencies[provider_to_check]["cross-providers-deps"]:
providers.add(dep_name)


def find_all_providers_affected(changed_files: tuple[str, ...]) -> set[str]:
Expand Down
17 changes: 8 additions & 9 deletions dev/breeze/tests/test_selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], output: str):
pytest.param(
(
"airflow/api/file.py",
"tests/providers/google/file.py",
"tests/providers/postgres/file.py",
),
{
"all-python-versions": "['3.7']",
Expand All @@ -76,8 +76,7 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], output: str):
"run-tests": "true",
"docs-build": "true",
"upgrade-to-newer-dependencies": "false",
"test-types": "API Always Providers[amazon,apache.beam,google,hashicorp,"
"microsoft.azure,presto,trino]",
"test-types": "API Always Providers[amazon,common.sql,google,postgres]",
},
id="API and providers tests and docs should run",
)
Expand Down Expand Up @@ -120,7 +119,7 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], output: str):
pytest.param(
(
"chart/aaaa.txt",
"tests/providers/google/file.py",
"tests/providers/postgres/file.py",
),
{
"all-python-versions": "['3.7']",
Expand All @@ -131,10 +130,10 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], output: str):
"docs-build": "true",
"run-kubernetes-tests": "true",
"upgrade-to-newer-dependencies": "false",
"test-types": "Always Providers[amazon,apache.beam,google,"
"hashicorp,microsoft.azure,presto,trino]",
"test-types": "Always Providers[amazon,common.sql,google,postgres]",
},
id="Helm tests, providers, kubernetes tests and docs should run",
id="Helm tests, providers (both upstream and downstream),"
"kubernetes tests and docs should run",
)
),
(
Expand Down Expand Up @@ -175,9 +174,9 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], output: str):
"docs-build": "true",
"run-kubernetes-tests": "true",
"upgrade-to-newer-dependencies": "false",
"test-types": "Always Providers[airbyte]",
"test-types": "Always Providers[airbyte,http]",
},
id="Helm tests, airbyte providers, kubernetes tests and "
id="Helm tests, airbyte/http providers, kubernetes tests and "
"docs should run even if unimportant files were added",
)
),
Expand Down