Add all dependent providers when running selective checks #26736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like we run tests for providers that use a changing provider, we need to run tests for any providers we use directly. So for example, if we change the `postgres` provider, both `common.sql` (which `postgres` uses) and `google` (which uses `postgres`) should be run.
dstandish
approved these changes
Sep 27, 2022
kaxil
approved these changes
Sep 27, 2022
potiuk
approved these changes
Sep 28, 2022
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Cool. Yeah. I thought this morning we should add it :)
Member
|
But selective checks are covered by unit tests, so they have to be fixed too :) |
potiuk
approved these changes
Sep 28, 2022
Member
|
Cool :) |
jedcunningham
deleted the
add_upstream_providers_to_selective_checks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like we run tests for providers that use a changing provider, we need to run tests for any providers we use directly.
So for example, if we change the
postgresprovider, bothcommon.sql(whichpostgresuses) andgoogle(which usespostgres) should be run.Related: #26734