Skip to content

Correct the description of "schema" #26730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fritz-astronomer wants to merge 2 commits into from
Closed

Correct the description of "schema" #26730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
460c8e7
Correct the description of "schema"
fritz-astronomer Sep 27, 2022
fd252bb
relabel schema to database
fritz-astronomer Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion airflow/providers/microsoft/mssql/hooks/mssql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"""Microsoft SQLServer hook module"""
from __future__ import annotations

from typing import Any
from typing import Any, Dict

import pymssql

Expand Down Expand Up @@ -51,6 +51,15 @@ def __init__(
self.schema = kwargs.pop("schema", None)
self._sqlalchemy_scheme = sqlalchemy_scheme

@staticmethod
def get_ui_field_behaviour() -> Dict[str, Any]:
"""Returns custom UI field behaviour for MSSQL Connection."""
return {
"relabeling": {
"schema": "Database",
},
Comment on lines +58 to +60
Copy link
Member

@ashb ashb Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add this to base DB api hook instead -- it'll right for all the subclasses much more than calling it schema currently is!

Copy link
Contributor Author

@fritz-astronomer fritz-astronomer Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#26732

Copy link
Contributor

@dstandish dstandish Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inheritance doesn't work for these methods though unfortunately.

aside... one thing that's unfortunate about relabeling is it doesn't help much when defining creds in env vars. for that case it's a bit nicer to have them named properly as extras... though not much to do about that now i guess.

}

@property
def connection_extra_lower(self) -> dict:
"""
Expand Down
4 changes: 2 additions & 2 deletions docs/apache-airflow-providers-microsoft-mssql/connections/mssql.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ Configuring the Connection
Host (required)
The host to connect to.

Schema (optional)
Specify the schema name to be used in the database.
Database (optional)
Specify the database name to be used

Login (required)
Specify the user name to connect.
Expand Down