Skip to content

Conversation

@fritz-astronomer
Copy link
Contributor

@fritz-astronomer fritz-astronomer commented Sep 27, 2022

misleading - the schema property actually needs to be the database property, as per source code

I am not sure if there's a better way to write this - open to suggestions / edits

@kaxil
Copy link
Member

kaxil commented Sep 27, 2022

cc @feluelle This is similar to #26436

Comment on lines +58 to +60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add this to base DB api hook instead -- it'll right for all the subclasses much more than calling it schema currently is!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inheritance doesn't work for these methods though unfortunately.

aside... one thing that's unfortunate about relabeling is it doesn't help much when defining creds in env vars. for that case it's a bit nicer to have them named properly as extras... though not much to do about that now i guess.

@dstandish
Copy link
Contributor

looks like just needs rebase

@dstandish
Copy link
Contributor

tests didn't run, can you rebase again... not sure why i don't see the option to do so...

fritz-astronomer and others added 2 commits November 4, 2022 14:54
misleading - the schema property actually needs to be the database property, as per source code
@potiuk
Copy link
Member

potiuk commented Nov 4, 2022

I saw it and rebased. Strange you couldn't :) (it appears when the fork has permission to update PR by maintainers - which is "on" by default when you fork).

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 20, 2022
@github-actions github-actions bot closed this Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants