-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Correct the description of "schema" #26730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add this to base DB api hook instead -- it'll right for all the subclasses much more than calling it schema currently is!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inheritance doesn't work for these methods though unfortunately.
aside... one thing that's unfortunate about relabeling is it doesn't help much when defining creds in env vars. for that case it's a bit nicer to have them named properly as extras... though not much to do about that now i guess.
|
looks like just needs rebase |
|
tests didn't run, can you rebase again... not sure why i don't see the option to do so... |
misleading - the schema property actually needs to be the database property, as per source code
|
I saw it and rebased. Strange you couldn't :) (it appears when the fork has permission to update PR by maintainers - which is "on" by default when you fork). |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
misleading - the schema property actually needs to be the database property, as per source code
I am not sure if there's a better way to write this - open to suggestions / edits