Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EmrEksCreateClusterOperator #25816

Merged
merged 5 commits into from
Aug 22, 2022
Merged

Implement EmrEksCreateClusterOperator #25816

merged 5 commits into from
Aug 22, 2022

Conversation

phanikumv
Copy link
Contributor

@phanikumv phanikumv commented Aug 19, 2022

This PR adds the implementation for a new operator called EmrEksCreateClusterOperator , which allows the users the ability to create an Amazon EMR on EKS virtual cluster from Airflow. Currently we only have the ability to submit jobs on EMR EKS virtual clusters.

cc @kaxil @ashb


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@ashb
Copy link
Member

ashb commented Aug 19, 2022

It's been a while since I looked at EMR, but is there a reason this needs to/should be a whole new operator, instead of just some new flags/arguments/mode to the existing Create EMR operator?

@phanikumv
Copy link
Contributor Author

It's been a while since I looked at EMR, but is there a reason this needs to/should be a whole new operator, instead of just some new flags/arguments/mode to the existing Create EMR operator?

@ashb - This is for creating a virtual EMR cluster on an EKS namespace, not the regular EMR cluster , which runs on EC2 machines

image

@ashb
Copy link
Member

ashb commented Aug 19, 2022

@phanikumv Yes, I got that.

I was asking if it made sense to have something lie EmrCreateClusterOperator(task_id='a', cluster_type='virtual') etc rather than a whole second operator. (It may not make sense. But that's what I'm asking)

for more details.

.. exampleinclude:: /../../airflow/providers/amazon/aws/example_dags/example_emr_eks.py
:language: python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It removes the indentation from the code

Suggested change
:language: python
:language: python
:dedent: 4

Copy link
Contributor

@dstandish dstandish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you can create, probably you also want to add delete

@potiuk
Copy link
Member

potiuk commented Aug 22, 2022

if you can create, probably you also want to add delete

Dapends ;) If you are cloud service provider, create works best :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants