Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on September 05, 2022 #26164

Closed
18 of 25 tasks
ashb opened this issue Sep 5, 2022 · 13 comments
Closed
18 of 25 tasks

Status of testing Providers that were prepared on September 05, 2022 #26164

ashb opened this issue Sep 5, 2022 · 13 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@ashb
Copy link
Member

ashb commented Sep 5, 2022

Body

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider amazon: 5.1.0rc1

Provider common.sql: 1.2.0rc1

Provider postgres: 5.2.1rc1

Provider presto: 4.0.1rc1

Provider sqlite: 3.2.1rc1

Provider trino: 4.0.1rc1

The guidelines on how to test providers can be found in

Verify providers by contributors

All users involved in the PRs:
@pankajastro @potiuk @dwreeves @Taragolis @vincbeck @kazanzhy @ashb @phanikumv @o-nikolas @alexandermalyga

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@ashb ashb added the kind:meta High-level information important to the community label Sep 5, 2022
@dwreeves
Copy link
Contributor

dwreeves commented Sep 5, 2022

My PR #25716 came about from testing for the Amazon provider package 5.0.0 and is a very simple 1 line change. (It was a PR for fixing a minor bug in 5.0.0rc3 from when I was testing that.) It does seem like it unfortunately made its way into the 5.0.0 release, hence why it's part of the 5.1.0 release cycle.

Previous issue when my testing uncovered it: #25640 (comment)

The 1 line change:

image

So I think you can ✔️ me as tested, since my PR was engendered from a test for 5.0.0?

@ashb
Copy link
Member Author

ashb commented Sep 5, 2022

@dwreeves thanks - the list was auto generated. Was your change in 5.0.0 of the provider do you know?

@Taragolis
Copy link
Contributor

#25810 - No more circular import issue
#25989, #26014, #26025 - Work as expected

@eladkal
Copy link
Contributor

eladkal commented Sep 5, 2022

@dwreeves thanks - the list was auto generated. Was your change in 5.0.0 of the provider do you know?

I dont think it was.
Amazon provider 5.0.0 was releases on 14-Aug
#25716 was merged on 15-Aug
The code with the amazon provider 5.0.0 tag doesnt have the changes in the PR:

@potiuk
Copy link
Member

potiuk commented Sep 5, 2022

@ashb @dwreeves - the change is properly included in the Changelog for 5.1.0:

  • fix bug construction of Connection object in version 5.0.0rc3 (#25716)

So I think what @dwreeves asks is to cick "OK" as "tested" - though it would be nice if you could test it yourselves @dwreeves :)

@potiuk
Copy link
Member

potiuk commented Sep 5, 2022

Common.sql lower-bounds are updated for those providers.

@potiuk potiuk added the testing status Status of testing releases label Sep 5, 2022
@kazanzhy
Copy link
Contributor

kazanzhy commented Sep 5, 2022

Checked #25855 with PostgresHook. Seems ok.

@dwreeves
Copy link
Contributor

dwreeves commented Sep 6, 2022

(Yeah sorry I wasn't clear with how I phrased that. "It made its way in" <-- "it" meaning the bug, not the fix for said bug.)

@phanikumv
Copy link
Contributor

Tested #25816 , it is working good.

image

@potiuk
Copy link
Member

potiuk commented Sep 6, 2022

Tested #25816 , it is working good.

What an interesting set of colours. I wonder if they mean something :)

@pankajastro
Copy link
Member

Worked as expected #25857 and #25975

@alexandermalyga
Copy link
Contributor

Tested #25939 with Trino, Presto and SQLite hooks. The issue has been solved and it works like expected.

@ashb
Copy link
Member Author

ashb commented Sep 8, 2022

Releasing now.

@ashb ashb closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests

9 participants