Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts that provide good links to example dags #24348

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 9, 2022

The documentation generated used "main" in the URL of the
example DAGs.

The generation of the links have been fixed in the #24307, but this
PR adds a tool that has been used to fix existing links in generated
documentation resulting in apache/airflow-site#610

Fixes: #24331


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Jun 9, 2022

cc: @deeptansh

@potiuk potiuk force-pushed the add-scripts-to-fix-example-dags-url-in-airflow-site branch from 23d4cae to fb5c31e Compare June 9, 2022 16:41
The documentation generated used "main" in the URL of the
example DAGs.

The generation of the links have been fixed in the apache#24307, but this
PR adds a tool that has been used to fix existing links in generated
documentation resulting in apache/airflow-site#610

Fixes: apache#24331
@potiuk potiuk force-pushed the add-scripts-to-fix-example-dags-url-in-airflow-site branch from fb5c31e to eba63e6 Compare June 9, 2022 17:07
Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 9, 2022
@potiuk
Copy link
Member Author

potiuk commented Jun 9, 2022

static checks passed . What can go wrong :)? Merging.

@potiuk potiuk merged commit 85c247a into apache:main Jun 9, 2022
@potiuk potiuk deleted the add-scripts-to-fix-example-dags-url-in-airflow-site branch June 9, 2022 17:33
ephraimbuddy pushed a commit that referenced this pull request Jun 30, 2022
The documentation generated used "main" in the URL of the
example DAGs.

The generation of the links have been fixed in the #24307, but this
PR adds a tool that has been used to fix existing links in generated
documentation resulting in apache/airflow-site#610

Fixes: #24331
(cherry picked from commit 85c247a)
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.3 milestone Jun 30, 2022
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Example DAGs" link under kubernetes-provider documentation is broken. Getting 404
4 participants