Update links to example dags to point to the right github URL #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The links to example DAGs from all versions of the providers pointed to "main" version of the example DAGS. This was wrong because it always shown the "latest" version of the examples, and it got additionally broken by AIP-47 where example_dags folder is essentially removed from all providers. This change updates the links to the "right" version of example dags for all providers, including cleaning up and removing the links that were pointing to non-existing example_dags folders (because example_dags were missing in the specific version of the provider). This is related to apache/airflow#24331
|
cc: @deeptansh |
kaxil
approved these changes
Jun 9, 2022
josh-fell
reviewed
Jun 9, 2022
josh-fell
reviewed
Jun 9, 2022
potiuk
added a commit
that referenced
this pull request
Jun 9, 2022
The #610 removed too many links because GitHub throttled checking if URLS are available. This PR is re-done with better checking for error code.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 9, 2022
The documentation generated used "main" in the URL of the example DAGs. The generation of the links have been fixed in the apache#24307, but this PR adds a tool that has been used to fix existing links in generated documentation resulting in apache/airflow-site#610 Fixes: apache#24331
potiuk
added a commit
that referenced
this pull request
Jun 9, 2022
The #610 removed too many links because GitHub throttled checking if URLS are available. This PR is re-done with better checking for error code.
potiuk
added a commit
to apache/airflow
that referenced
this pull request
Jun 9, 2022
The documentation generated used "main" in the URL of the example DAGs. The generation of the links have been fixed in the #24307, but this PR adds a tool that has been used to fix existing links in generated documentation resulting in apache/airflow-site#610 Fixes: #24331
ephraimbuddy
pushed a commit
to apache/airflow
that referenced
this pull request
Jun 30, 2022
The documentation generated used "main" in the URL of the example DAGs. The generation of the links have been fixed in the #24307, but this PR adds a tool that has been used to fix existing links in generated documentation resulting in apache/airflow-site#610 Fixes: #24331 (cherry picked from commit 85c247a)
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
The documentation generated used "main" in the URL of the example DAGs. The generation of the links have been fixed in the #24307, but this PR adds a tool that has been used to fix existing links in generated documentation resulting in apache/airflow-site#610 Fixes: #24331 (cherry picked from commit 85c247ae10da5ee93f26352d369f794ff4f2e47c) GitOrigin-RevId: f5dd1f3f6b939b4cb60f092430894d2fe6b12243
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
The documentation generated used "main" in the URL of the example DAGs. The generation of the links have been fixed in the #24307, but this PR adds a tool that has been used to fix existing links in generated documentation resulting in apache/airflow-site#610 Fixes: #24331 (cherry picked from commit 85c247ae10da5ee93f26352d369f794ff4f2e47c) GitOrigin-RevId: f5dd1f3f6b939b4cb60f092430894d2fe6b12243
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
The documentation generated used "main" in the URL of the example DAGs. The generation of the links have been fixed in the #24307, but this PR adds a tool that has been used to fix existing links in generated documentation resulting in apache/airflow-site#610 Fixes: #24331 GitOrigin-RevId: 85c247ae10da5ee93f26352d369f794ff4f2e47c
potiuk
added a commit
that referenced
this pull request
Jun 17, 2023
The links to example DAGs from all versions of the providers pointed to "main" version of the example DAGS. This was wrong because it always shown the "latest" version of the examples, and it got additionally broken by AIP-47 where example_dags folder is essentially removed from all providers. This change updates the links to the "right" version of example dags for all providers, including cleaning up and removing the links that were pointing to non-existing example_dags folders (because example_dags were missing in the specific version of the provider). This is related to apache/airflow#24331
potiuk
added a commit
that referenced
this pull request
Jun 17, 2023
The #610 removed too many links because GitHub throttled checking if URLS are available. This PR is re-done with better checking for error code.
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
The documentation generated used "main" in the URL of the example DAGs. The generation of the links have been fixed in the #24307, but this PR adds a tool that has been used to fix existing links in generated documentation resulting in apache/airflow-site#610 Fixes: #24331 (cherry picked from commit 85c247ae10da5ee93f26352d369f794ff4f2e47c) GitOrigin-RevId: f5dd1f3f6b939b4cb60f092430894d2fe6b12243
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 18, 2024
The documentation generated used "main" in the URL of the example DAGs. The generation of the links have been fixed in the #24307, but this PR adds a tool that has been used to fix existing links in generated documentation resulting in apache/airflow-site#610 Fixes: #24331 GitOrigin-RevId: 85c247ae10da5ee93f26352d369f794ff4f2e47c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The links to example DAGs from all versions of the providers
pointed to "main" version of the example DAGS. This was wrong
because it always shown the "latest" version of the examples,
and it got additionally broken by AIP-47 where example_dags
folder is essentially removed from all providers.
This change updates the links to the "right" version of
example dags for all providers, including cleaning up
and removing the links that were pointing to non-existing
example_dags folders (because example_dags were missing in
the specific version of the provider).
This is related to apache/airflow#24331