Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces the usage of postgres:// with postgresql:// #21205

Merged
merged 1 commit into from
Jan 30, 2022

Commits on Jan 29, 2022

  1. Replaces the usage of postgres:// with postgresql://

    After releasing 3.4.4 we can finally migrate to SQLAlchemy 1.4,
    however SQLAlchemy 1.4 removed the use of postgres:// as valid
    specification for Postgres DB SQL (leaving only postgresql://)
    
    Due to that we need to change:
    
    * postgres provider to return postgresql:// with get_db_uri()
    * fix a number of tests that expected postgres://
    
    We cannot do much if someone uses postgres:// specification.
    Technically it might be seen as breaking change, but this is not
    an airflow breaking change and users could still use SQLAlchemy
    1.3 to keep the old prefix, so we can introduce this change
    in Airflow without raising the major version.
    
    Details in the [SQLAlchemy Changelog](https://docs.sqlalchemy.org/en/14/changelog/changelog_14.html#change-3687655465c25a39b968b4f5f6e9170b).
    potiuk committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    9676523 View commit details
    Browse the repository at this point in the history