Replaces the usage of postgres:// with postgresql:// #21205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
fix-sqlalchemy-postgresql
branch
from
642b732
to
5a1c69a
Compare
uranusjr
reviewed
Jan 29, 2022
uranusjr
reviewed
Jan 29, 2022
|
Yep. solved. |
|
I found a note in changelog:
|
|
Cool. I was looking for it and did not find it before (but I did not look for a long time)!. Updating, |
After releasing 3.4.4 we can finally migrate to SQLAlchemy 1.4, however SQLAlchemy 1.4 removed the use of postgres:// as valid specification for Postgres DB SQL (leaving only postgresql://) Due to that we need to change: * postgres provider to return postgresql:// with get_db_uri() * fix a number of tests that expected postgres:// We cannot do much if someone uses postgres:// specification. Technically it might be seen as breaking change, but this is not an airflow breaking change and users could still use SQLAlchemy 1.3 to keep the old prefix, so we can introduce this change in Airflow without raising the major version. Details in the [SQLAlchemy Changelog](https://docs.sqlalchemy.org/en/14/changelog/changelog_14.html#change-3687655465c25a39b968b4f5f6e9170b).
potiuk
force-pushed
the
fix-sqlalchemy-postgresql
branch
from
9d9d9e3
to
9676523
Compare
|
Updated! |
eladkal
approved these changes
Jan 30, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 31, 2022
The recent release of FAB 3.4.4 has unblocked us from upgrading SQLAlchemy to 1.4.* version. We wanted to do it for quite some time however upgrading to 1.4.* of sqlalchemy and allowing our users to use it for 2.2.4 is a bit risky. We are fixing resulting "aftermath" in the main branch and as of this commit there are two fixes merged and remaining MsSQL problem. The MSSql problem does not affect 2.2.4 as MsSQL will be available only starting from 2.3.0, however the two other problems have shown that SQLAlchemy has a potential to break things and we might want to test it more thoroughly before releasing 2.3.0. The problems in question are apache#21205 and apache#21228. Both were only test problems but the indicate that there might be more hidden issues involved. In order to limit risks, this PR proposes to limit SQLAlchemy for 2.2.* to < 1.4.0. This will allow to upgrade FAB and related dependencies without opening up Airflow to upgrade to SQLAlchemy 1.4 (yet).
potiuk
added a commit
that referenced
this pull request
Jan 31, 2022
The recent release of FAB 3.4.4 has unblocked us from upgrading SQLAlchemy to 1.4.* version. We wanted to do it for quite some time however upgrading to 1.4.* of sqlalchemy and allowing our users to use it for 2.2.4 is a bit risky. We are fixing resulting "aftermath" in the main branch and as of this commit there are two fixes merged and remaining MsSQL problem. The MSSql problem does not affect 2.2.4 as MsSQL will be available only starting from 2.3.0, however the two other problems have shown that SQLAlchemy has a potential to break things and we might want to test it more thoroughly before releasing 2.3.0. The problems in question are #21205 and #21228. Both were only test problems but the indicate that there might be more hidden issues involved. In order to limit risks, this PR proposes to limit SQLAlchemy for 2.2.* to < 1.4.0. This will allow to upgrade FAB and related dependencies without opening up Airflow to upgrade to SQLAlchemy 1.4 (yet).
54 tasks
74 tasks
jedcunningham
pushed a commit
that referenced
this pull request
Feb 10, 2022
The recent release of FAB 3.4.4 has unblocked us from upgrading SQLAlchemy to 1.4.* version. We wanted to do it for quite some time however upgrading to 1.4.* of sqlalchemy and allowing our users to use it for 2.2.4 is a bit risky. We are fixing resulting "aftermath" in the main branch and as of this commit there are two fixes merged and remaining MsSQL problem. The MSSql problem does not affect 2.2.4 as MsSQL will be available only starting from 2.3.0, however the two other problems have shown that SQLAlchemy has a potential to break things and we might want to test it more thoroughly before releasing 2.3.0. The problems in question are #21205 and #21228. Both were only test problems but the indicate that there might be more hidden issues involved. In order to limit risks, this PR proposes to limit SQLAlchemy for 2.2.* to < 1.4.0. This will allow to upgrade FAB and related dependencies without opening up Airflow to upgrade to SQLAlchemy 1.4 (yet).
jedcunningham
pushed a commit
that referenced
this pull request
Feb 17, 2022
The recent release of FAB 3.4.4 has unblocked us from upgrading SQLAlchemy to 1.4.* version. We wanted to do it for quite some time however upgrading to 1.4.* of sqlalchemy and allowing our users to use it for 2.2.4 is a bit risky. We are fixing resulting "aftermath" in the main branch and as of this commit there are two fixes merged and remaining MsSQL problem. The MSSql problem does not affect 2.2.4 as MsSQL will be available only starting from 2.3.0, however the two other problems have shown that SQLAlchemy has a potential to break things and we might want to test it more thoroughly before releasing 2.3.0. The problems in question are #21205 and #21228. Both were only test problems but the indicate that there might be more hidden issues involved. In order to limit risks, this PR proposes to limit SQLAlchemy for 2.2.* to < 1.4.0. This will allow to upgrade FAB and related dependencies without opening up Airflow to upgrade to SQLAlchemy 1.4 (yet).
84 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After releasing 3.4.4 we can finally migrate to SQLAlchemy 1.4,
however SQLAlchemy 1.4 removed the use of postgres:// as valid
specification for Postgres DB SQL (leaving only postgresql://)
Due to that we need to change:
We cannot do much if someone uses postgres:// specification.
Technically it might be seen as breaking change, but this is not
an airflow breaking change and users could still use SQLAlchemy
1.3 to keep the old prefix, so we can introduce this change
in Airflow without raising the major version.
Details in the SQLAlchemy Changelog.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.