Consolidate method names between Airflow Security Manager and FAB default #18726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhtimmins
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
jhtimmins
force-pushed
the
use-new-fab-names-in-base-sm
branch
2 times, most recently
from
13b247f to
ae1ec97
Compare
jhtimmins
force-pushed
the
use-new-fab-names-in-base-sm
branch
from
ae1ec97 to
0c297fa
Compare
jedcunningham
approved these changes
Oct 18, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
1 similar comment
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
jhtimmins
force-pushed
the
use-new-fab-names-in-base-sm
branch
from
0c297fa to
1f591a0
Compare
uranusjr
approved these changes
Oct 22, 2021
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
…ault (apache#18726) * Replace add_view_menu with create_resource. * Replace add_permission_view_menu with create_permission. * Replace find_permission_view_menu with get_permission. * Replace find_view_menu with get_resource. * Replace get_all_view_menu with get_all_resources. * Replace find_permission with get_action. * Replace del_permission_view_menu with delete_permission. * Replace del_view_menu with delete_resource. * Replace del_permission with delete_action. * Replace add_permission_role with add_permission_to_role. * Replace find_permissions_view_menu with get_resource_permissions. * Replace self.del_permission_role wth remove_permission_from_role. * Replace exist_permission_on_roles with permission_exists_in_one_or_more_roles. * Replace find_roles_permission_view_menus with filter_roles_by_perm_with_action. * Replace get_db_role_permissions with get_role_permissions_from_db. * Replace add_permission with create_action. * Remove unused exist_permission_on_view function. * Rename local variables. * Remove sqla model names from SecurityManager base class. * Update names in add_permissions_view. * Flake8. * Use updated perm names. * Use updated perm names for local vars. * Use black. * Reorder import statements. * Remove accidental renaming of BaseSecurityManager.roles.
ephraimbuddy
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
This follows the work completed in #16647, where I copied the base FAB security manager classes into the Airflow codebase. This is a step forward in merging the Airflow-specific security manager code with the default FAB security manager code.