Skip to content

Conversation

@jhtimmins
Copy link
Contributor

@jhtimmins jhtimmins commented Jun 25, 2021

As one of the first steps in refactoring Airflow's usage of the FAB security manager, copy FAB's base SecurityManager classes into Airflow.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jun 25, 2021
@jhtimmins jhtimmins requested a review from kaxil June 25, 2021 02:48
@uranusjr
Copy link
Member

Do we want to keep FAB in the name? If we end up removing Rlask-Appbuilder altogether, the name reference may feel confusing to newcomers.

@jhtimmins
Copy link
Contributor Author

jhtimmins commented Jun 25, 2021

Do we want to keep FAB in the name? If we end up removing Flask-Appbuilder altogether, the name reference may feel confusing to newcomers.

@uranusjr I'm refactoring it in pieces, so I plan to change the naming in a PR that's coming shortly. For now though, it exactly matches the FAB architecture and references FAB models/concepts.

@uranusjr
Copy link
Member

I see, thanks for the clarification.

@jhtimmins jhtimmins force-pushed the replace-fab-base-security-manager branch from d4a0566 to fbac909 Compare June 28, 2021 20:43
@jhtimmins jhtimmins requested a review from kaxil June 28, 2021 20:45
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Aug 14, 2021
@jhtimmins jhtimmins force-pushed the replace-fab-base-security-manager branch from fbac909 to b0d3faa Compare August 18, 2021 22:36
@github-actions github-actions bot closed this Aug 25, 2021
@ashb ashb reopened this Sep 2, 2021
@github-actions github-actions bot closed this Sep 8, 2021
@jhtimmins jhtimmins reopened this Sep 18, 2021
@jhtimmins jhtimmins force-pushed the replace-fab-base-security-manager branch from 78c9e09 to ecfaad8 Compare September 18, 2021 02:53
@jhtimmins jhtimmins force-pushed the replace-fab-base-security-manager branch from be7e965 to f286206 Compare September 21, 2021 01:01
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Sep 22, 2021
@github-actions github-actions bot closed this Sep 28, 2021
@jhtimmins jhtimmins reopened this Sep 28, 2021
@jhtimmins jhtimmins force-pushed the replace-fab-base-security-manager branch from 23b8020 to bb64f41 Compare September 28, 2021 20:31
@jhtimmins jhtimmins merged commit 48d4c5d into apache:main Sep 28, 2021
@jhtimmins jhtimmins deleted the replace-fab-base-security-manager branch September 28, 2021 21:29
@ephraimbuddy ephraimbuddy added type:misc/internal Changelog: Misc changes that should appear in change log and removed stale Stale PRs per the .github/workflows/stale.yml policy file labels Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants