feat(plugin-chart-echart): New Tree chart #1018

mayurnewase · 2021-03-22T15:40:30Z

🏆 Enhancements
Added new Echart's Tree chart
Couldn't find a suitable table in existing examples, so added my own.
Deployment: https://superset-ui-5zve2b551-superset.vercel.app/?path=/story/chart-plugins-plugin-chart-echarts-tree--tree
SS (controls are not updated)

vercel · 2021-03-22T15:40:34Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/D9aGdWRZ2xsMJ3131PQnMdKweCaf
✅ Preview: https://superset-ui-git-fork-mayurnewase-ui-echart-tree-superset.vercel.app

villebro

Thanks so much for taking this on! A few comments (sorry if I barged in on a WIP that wasn't supposed to be reviewed yet).

plugins/plugin-chart-echarts/src/Tree/controlPanel.tsx

plugins/plugin-chart-echarts/src/Tree/transformProps.ts

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

…set-ui into ui-echart-tree

plugins/plugin-chart-echarts/src/Tree/transformProps.ts

codecov · 2021-03-30T14:34:05Z

Codecov Report

Merging #1018 (bdf9d8c) into master (f9dec07) will increase coverage by 0.43%.
The diff coverage is 85.50%.

@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
+ Coverage   28.35%   28.78%   +0.43%     
==========================================
  Files         448      455       +7     
  Lines        9057     9126      +69     
  Branches     1423     1436      +13     
==========================================
+ Hits         2568     2627      +59     
- Misses       6289     6296       +7     
- Partials      200      203       +3

Impacted Files	Coverage Δ
...gins/plugin-chart-echarts/src/Tree/EchartsTree.tsx	`0.00% <0.00%> (ø)`
plugins/plugin-chart-echarts/src/Tree/index.ts	`0.00% <0.00%> (ø)`
...ins/plugin-chart-echarts/src/Tree/controlPanel.tsx	`60.00% <60.00%> (ø)`
...ns/plugin-chart-echarts/src/Tree/transformProps.ts	`91.37% <91.37%> (ø)`
...lugins/plugin-chart-echarts/src/Tree/buildQuery.ts	`100.00% <100.00%> (ø)`
plugins/plugin-chart-echarts/src/Tree/constants.ts	`100.00% <100.00%> (ø)`
plugins/plugin-chart-echarts/src/Tree/types.ts	`100.00% <100.00%> (ø)`
plugins/plugin-chart-echarts/src/BoxPlot/types.ts	`0.00% <0.00%> (ø)`
...lugins/plugin-chart-echarts/src/Pie/EchartsPie.tsx	`0.00% <0.00%> (ø)`
...ns/plugin-chart-echarts/src/Radar/EchartsRadar.tsx	`0.00% <0.00%> (ø)`
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9dec07...bdf9d8c. Read the comment docs.

plugins/plugin-chart-echarts/src/Tree/controlPanel.tsx

junlincc · 2021-05-05T05:28:11Z

@mayurnewase Hi Mayur, many thanks for the PR. it has been open for a long time, do you think it's ready to merge? I need help to get it to the other main repo for testing. @villebro

villebro · 2021-05-05T06:07:03Z

@mayurnewase I'm reviewing now; can you rebase to resolve the conflict?

villebro

Looks mostly good - a minor change recommendation on the orientation control labels. Also, I was unable to get the radio buttons to work correctly despite nuking superset-ui, linking core and chart-controls etc. Probably just my env that doesn't work properly, but might be a good idea to double check that the control panel works correctly:

plugins/plugin-chart-echarts/src/Tree/controlPanel.tsx

plugins/plugin-chart-echarts/src/Tree/types.ts

plugins/plugin-chart-echarts/src/Tree/transformProps.ts

mayurnewase · 2021-05-06T13:54:46Z

Radio button signature was updated in #1019

villebro

LGTM, thanks for all the hard work on this awesome plugin! 🚀

* initial * tests added,1 typing issue present * remove log * remove color * remove duplicate tooltip * Update plugins/plugin-chart-echarts/src/Tree/transformProps.ts Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * clean * merge * optional name column,more tests... * bug fix * remove unused imports * lint * bug fix * tying fix * clean,typing fix * stories added * optional metric control * bigger thumbnail * optional root node name * storybokk updated * children list seperated instead of mutating data,if root node not provided defaault it to node with most children * remove logs,optimization needed * find best node if root not provided,use seperate children list to avoid issues if column name is children * remove unused import * type fix * Update transformProps.ts * Update debugging.md * better todo * updated radio button with new signature Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

…)" This reverts commit e03c37e.

mayurnewase added 4 commits March 22, 2021 14:56

initial

555d5e7

tests added,1 typing issue present

d50f080

remove log

9c4a9a0

remove color

75a84de

mayurnewase requested a review from a team as a code owner March 22, 2021 15:40

vercel bot had a problem deploying to Preview March 22, 2021 15:40 Failure

mayurnewase changed the title ~~feat(plugin-chart-echart): New Tree chart~~ [WIP] feat(plugin-chart-echart): New Tree chart Mar 22, 2021

remove duplicate tooltip

9b61ad4

vercel bot had a problem deploying to Preview March 22, 2021 15:46 Failure

villebro reviewed Mar 23, 2021

View reviewed changes

Update plugins/plugin-chart-echarts/src/Tree/transformProps.ts

3c9cc92

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

vercel bot had a problem deploying to Preview March 24, 2021 05:43 Failure

mayurnewase added 3 commits March 30, 2021 18:22

clean

8a129d5

Merge branch 'ui-echart-tree' of https://github.com/mayurnewase/super…

28938fa

…set-ui into ui-echart-tree

merge

5250f81

vercel bot had a problem deploying to Preview March 30, 2021 12:53 Failure

mayurnewase changed the title ~~[WIP] feat(plugin-chart-echart): New Tree chart~~ feat(plugin-chart-echart): New Tree chart Mar 30, 2021

optional name column,more tests...

846dd54

vercel bot had a problem deploying to Preview March 30, 2021 13:32 Failure

bug fix

990c67f

vercel bot had a problem deploying to Preview March 30, 2021 13:38 Failure

remove unused imports

7fbc05d

vercel bot deployed to Preview March 30, 2021 13:44 View deployment

mayurnewase commented Mar 30, 2021

View reviewed changes

plugins/plugin-chart-echarts/src/Tree/transformProps.ts Outdated Show resolved Hide resolved

mayurnewase commented Mar 30, 2021

View reviewed changes

plugins/plugin-chart-echarts/src/Tree/transformProps.ts Outdated Show resolved Hide resolved

lint

46a17a9

vercel bot deployed to Preview March 30, 2021 14:21 View deployment

mayurnewase requested a review from villebro March 30, 2021 14:34

mayurnewase requested a review from suddjian April 15, 2021 17:31

remove unused import

b4799d9

vercel bot had a problem deploying to Preview April 15, 2021 17:35 Failure

mayurnewase commented Apr 15, 2021

View reviewed changes

plugins/plugin-chart-echarts/src/Tree/controlPanel.tsx Show resolved Hide resolved

type fix

979a4ba

vercel bot deployed to Preview April 15, 2021 17:53 View deployment

Merge branch 'master' into ui-echart-tree

f1d9c41

vercel bot deployed to Preview April 16, 2021 14:31 View deployment

Update transformProps.ts

f087104

vercel bot deployed to Preview April 17, 2021 01:22 View deployment

villebro reviewed May 5, 2021

View reviewed changes

mayurnewase added 2 commits May 5, 2021 20:13

update with comments

c9ee6e5

update with comments

56a610b

vercel bot deployed to Preview May 5, 2021 14:46 View deployment

Update debugging.md

c2da65e

vercel bot deployed to Preview May 5, 2021 14:53 View deployment

better todo

e810d14

vercel bot deployed to Preview May 5, 2021 15:04 View deployment

updated radio button with new signature

bdf9d8c

vercel bot deployed to Preview May 6, 2021 13:52 View deployment

mayurnewase mentioned this pull request May 6, 2021

feat: New Tree chart apache/superset#14503

Closed

8 tasks

villebro approved these changes May 6, 2021

View reviewed changes

villebro merged commit 77ddcce into apache-superset:master May 6, 2021

stephenLYZ added a commit to stephenLYZ/superset-ui that referenced this pull request May 6, 2021

Revert "feat(plugin-chart-echart): New Tree chart (apache-superset#1018…

9374ca4

…)" This reverts commit e03c37e.

villebro mentioned this pull request May 7, 2021

chore: bump superset-ui to 0.17.44 apache/superset#14515

Merged

8 tasks

mayurnewase mentioned this pull request May 7, 2021

feat(viz): new tree chart apache/superset#14516

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plugin-chart-echart): New Tree chart #1018

feat(plugin-chart-echart): New Tree chart #1018

mayurnewase commented Mar 22, 2021 •

edited

Loading

vercel bot commented Mar 22, 2021 •

edited

Loading

villebro left a comment

codecov bot commented Mar 30, 2021 •

edited

Loading

junlincc commented May 5, 2021

villebro commented May 5, 2021

villebro left a comment

mayurnewase commented May 6, 2021

villebro left a comment

feat(plugin-chart-echart): New Tree chart #1018

feat(plugin-chart-echart): New Tree chart #1018

Conversation

mayurnewase commented Mar 22, 2021 • edited Loading

vercel bot commented Mar 22, 2021 • edited Loading

villebro left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 30, 2021 • edited Loading

Codecov Report

junlincc commented May 5, 2021

villebro commented May 5, 2021

villebro left a comment

Choose a reason for hiding this comment

mayurnewase commented May 6, 2021

villebro left a comment

Choose a reason for hiding this comment

mayurnewase commented Mar 22, 2021 •

edited

Loading

vercel bot commented Mar 22, 2021 •

edited

Loading

codecov bot commented Mar 30, 2021 •

edited

Loading