This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Fix invalid secret name, fixes #620 #621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported to apache-spark-on-k8s#620 invalid secret names are being generated by Spark on K8S. This commit adds a toLowerCase to the generated name to pass the validation regex
|
Already fixed by #612 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #620 invalid secret names are being generated by Spark on K8S. This commit adds a
toLowerCaseto the generated name to pass the validation regex. The specific problem is that the current name generation creates a segment containing K8S requires that each segment start with an alphabetic character.How was this patch tested?
Tested against a secure HDFS cluster to verify successful mounting of the Hadoop Kerberos secret volume