This repository was archived by the owner on Jan 9, 2020. It is now read-only.
remove camel case naming in kerberos secret names #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aberey can you bring the PR up-to-date with the base branch? |
|
Thank you for this! @aberey. This should be caught in the integration tests in the integration tests that I am writing. |
The names are currently used when HadoopKerberosKeytabResolverStep tries to safe the kerberos delegation token into a kubernete secret. However, the current camel case values will cause a io.fabric8.kubernetes.client.KubernetesClientException stating the following: a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
aberey
force-pushed
the
kerberos-delegation-token-fix
branch
from
ee1c50e to
0ef937f
Compare
|
@liyinan926 I just rebased the PR on the latest |
|
Thanks @aberey merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a bugfix for PR #540 (Basic Secure HDFS Support).
The
HadoopKerberosKeytabResolverStepcurrently uses the constantKERBEROS_DELEGEGATION_TOKEN_SECRET_NAMEwhen storing the Kerberosdelegation token into a Kubernetes secret - this however causes a
KubernetesClientExceptionstating the following as secret names are supposed to adhere to RFC 1123:The code in question is https://github.com/apache-spark-on-k8s/spark/blob/branch-2.2-kubernetes/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/submitsteps/hadoopsteps/HadoopKerberosKeytabResolverStep.scala#L102
The problem is that the current constants are using camel case, so I have changed the values to not use any uppercase characters anymore.
How was this patch tested?
This was tested manually (against a Kubernetes cluster with version v1.8.5), since the currently implemented unit tests only use mocks and the above Exception is only thrown when the actual Kubernetes API is called.