Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to adjust window ratios #482

Merged
merged 34 commits into from
Aug 2, 2024
Merged

Add ability to adjust window ratios #482

merged 34 commits into from
Aug 2, 2024

Conversation

DOD-101
Copy link
Contributor

@DOD-101 DOD-101 commented Jun 30, 2024 •
edited
Loading

resolve #480

This PR adds the following:

  1. A new layout section to the config which contains options for adjusting the ratios of windows found within the app
  2. Move playback_window_width (now playback_window_height) & playback_window_position to new layout section
  3. Update docs accordingly

@DOD-101
Add config options for library section width
c662594 
It is now possible to adjust the width of the three sections in the
library view.
@DOD-101
Add check to config width values
6c38580 
Added a check to make sure that album_width + playlist_width isn't too
large.
@DOD-101
Clean up code and rename config values
abb8b92
@DOD-101
Add documentation for new config options
7b48c95
aome510
aome510 reviewed Jul 2, 2024
View reviewed changes
spotify_player/src/ui/page.rs Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
@aome510
Copy link
Owner

aome510 commented Jul 2, 2024

I don't think this PR is related to #278. 278 asks for adjustable columns in a track table specifically not windows in the library page.

@DOD-101
Remove error handling code
21f5935 
Change code back to simply error instead of catching the error and
setting defaults.
@DOD-101 DOD-101 marked this pull request as draft July 10, 2024 14:27
DOD-101 and others added 15 commits July 17, 2024 18:39
@DOD-101
Merge branch 'master' into add-278-2024-06-30
6780cbe
@aNNiMON @DOD-101
skip single selection for artist actions (aome510#507)
33153b5
@aNNiMON @DOD-101
show album types in the artist context (aome510#508)
ea32a53
@aNNiMON @DOD-101
Fix mismatched arguments (aome510#511)
e69394f
@puuuuh @aome510 @DOD-101
Use BufReader/BufWriter for data from file cache (aome510#510)
bde96bd 
* Use BufReader/BufWriter for data from file cache

* formatting

---------

Co-authored-by: user <puh@p>
Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
@DOD-101
New implementation of layout config
742b307 
There is now a section which will contain all of the layout config
options.
@DOD-101
Shortened config-option names
70f3b1a
@DOD-101
Add default method to LayoutConfig
775c173
@DOD-101
Merge branch 'master' into add-278-2024-06-30
ae01058
@DOD-101
Shorten library_page to library
945109b
@DOD-101
Add docs/config.md section
319f0c2 
Add a section detailing the configuration for the layout options.
@DOD-101
Add checks to ensure that Layout config values are valid
14426e6
@DOD-101
Add CheckValues trait
2b29b2a
@DOD-101
Add artist layout options
0205300
@DOD-101
Updated documentation
1f96a12
@DOD-101 DOD-101 changed the title Add ability to adjust window sizes in library Add ability to adjust window ratios Jul 21, 2024
@DOD-101 DOD-101 marked this pull request as ready for review July 21, 2024 20:20
@DOD-101
Code cleanup
774196e 
Clean up of code and removal of clippy errors
@DOD-101 DOD-101 requested a review from aome510 July 23, 2024 17:34
@DOD-101 DOD-101 mentioned this pull request Jul 31, 2024
Merged
aome510
aome510 requested changes Aug 1, 2024
View reviewed changes
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
spotify_player/src/ui/page.rs Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
spotify_player/src/config/mod.rs Outdated Show resolved Hide resolved
spotify_player/src/ui/page.rs Outdated Show resolved Hide resolved
spotify_player/src/ui/page.rs Outdated Show resolved Hide resolved
@DOD-101
Copy link
Contributor Author

DOD-101 commented Aug 1, 2024

I have made all the changes you have requested.

I apologize for the amount of problems with the code. I am new to rust and contributing to large public projects.

@DOD-101 DOD-101 requested a review from aome510 August 1, 2024 08:29
aome510
aome510 reviewed Aug 1, 2024
View reviewed changes
Copy link
Owner

@aome510 aome510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. Only a few comments left. Can you also update the default values in https://github.com/aome510/spotify-player/blob/master/examples/app.toml as well?

docs/config.md Outdated Show resolved Hide resolved
spotify_player/src/config/mod.rs Outdated Show resolved Hide resolved
spotify_player/src/config/mod.rs Outdated Show resolved Hide resolved
@aome510
Copy link
Owner

aome510 commented Aug 1, 2024

I apologize for the amount of problems with the code. I am new to rust and contributing to large public projects.

No need to apologize lol. Instead, I appreciate that you spend your own time learning a new (famously hard) language and contributing to this project 🙇

@DOD-101 DOD-101 requested a review from aome510 August 1, 2024 17:20
@aome510 aome510 merged commit 2030b4e into aome510:master Aug 2, 2024
3 checks passed
@DOD-101 DOD-101 deleted the add-278-2024-06-30 branch August 5, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aome510 aome510 aome510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of adjustable widget sizes
4 participants
@DOD-101 @aome510 @aNNiMON @puuuuh