Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of adjustable widget sizes #480

Closed
DOD-101 opened this issue Jun 29, 2024 · 0 comments · Fixed by #482
Closed

Implementation of adjustable widget sizes #480

DOD-101 opened this issue Jun 29, 2024 · 0 comments · Fixed by #482
Labels
enhancement New feature or request

Comments

@DOD-101
Copy link
Contributor

DOD-101 commented Jun 29, 2024

While working on implementing different sized widget in the library, I have come across two different way to implement the setting of different widget sizes in the config.

Option 1

Have two config values album width & playlist width and have them be the percentage values used in the layout.

Pros

  • Super simple to understand

Cons

  • Having two values to configure the size of the widgets seems very unclean
  • It is easily possible to write values which are too large and would then cause errors, which need to be checked for

Option 2

Add a ration to the config such as 3:2:4, which will define the size of the different widgets. See: CSS-Flex

Pros

  • One value to define the size of all relevant widgets
  • Errors can be entirely avoided
  • Easier to scale to different places in the app

Cons

  • A tiny bit harder to understand
  • Will require adding a new "type" to the config
@aome510 aome510 added the enhancement New feature or request label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants