Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1: Feature - Remove accounts executable flag checks (backport of #2182) #3470

Open
wants to merge 1 commit into
base: v2.1
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 4, 2024

See SIMD-0162


This is an automatic backport of pull request #2182 done by Mergify.

* Adds the feature.

* Adds the feature gate logic.

* Adjusts tests.

* Adds deprecation attributes.

* Set is_executable flag upon initialization in loader-v4.

(cherry picked from commit 3bf9c2e)
@mergify mergify bot requested a review from a team as a code owner November 4, 2024 21:13
@mergify mergify bot assigned Lichtso Nov 4, 2024
Copy link
Author

mergify bot commented Nov 4, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso requested a review from HaoranYi November 4, 2024 21:18
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants