Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Remove accounts executable flag checks #2182

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Feature - Remove accounts executable flag checks #2182

merged 5 commits into from
Nov 4, 2024

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Jul 18, 2024 •
edited
Loading

See SIMD-0162

@Lichtso Lichtso force-pushed the feature/remove_accounts_executable_flag_checks branch from cef7572 to 7e815e1 Compare July 18, 2024 08:42
@Lichtso Lichtso mentioned this pull request Jul 18, 2024
Closed
@Lichtso Lichtso force-pushed the feature/remove_accounts_executable_flag_checks branch from 7e815e1 to f304b9e Compare July 24, 2024 11:18
@Lichtso Lichtso force-pushed the feature/remove_accounts_executable_flag_checks branch 3 times, most recently from 71a4633 to 8a5257e Compare July 31, 2024 18:55
HaoranYi
HaoranYi reviewed Aug 5, 2024
View reviewed changes
log-collector/src/lib.rs Outdated Show resolved Hide resolved
HaoranYi
HaoranYi reviewed Aug 5, 2024
View reviewed changes
log-collector/src/lib.rs Outdated Show resolved Hide resolved
@Lichtso Lichtso force-pushed the feature/remove_accounts_executable_flag_checks branch from 8a5257e to 8631287 Compare August 5, 2024 07:35
@mergify Mergify
Copy link

mergify bot commented Aug 9, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso mentioned this pull request Aug 21, 2024
Closed
@Lichtso Lichtso mentioned this pull request Sep 5, 2024
Merged
@Lichtso Lichtso force-pushed the feature/remove_accounts_executable_flag_checks branch from 5fbb7c5 to e7cff7e Compare November 4, 2024 12:45
@Lichtso Lichtso force-pushed the feature/remove_accounts_executable_flag_checks branch from e7cff7e to 0036428 Compare November 4, 2024 12:56
@Lichtso Lichtso force-pushed the feature/remove_accounts_executable_flag_checks branch from 0036428 to 8399add Compare November 4, 2024 13:05
@Lichtso Lichtso marked this pull request as ready for review November 4, 2024 14:11
HaoranYi
HaoranYi approved these changes Nov 4, 2024
View reviewed changes
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

We are one step closer to deprecate "executable".

@Lichtso Lichtso added the v2.1 Backport to v2.1 branch label Nov 4, 2024
@Lichtso Lichtso merged commit 3bf9c2e into anza-xyz:master Nov 4, 2024
51 checks passed
@mergify Mergify
Copy link

mergify bot commented Nov 4, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Nov 4, 2024
@Lichtso @mergify
Feature - Remove accounts executable flag checks (#2182)
b19cbb6 
* Adds the feature.

* Adds the feature gate logic.

* Adjusts tests.

* Adds deprecation attributes.

* Set is_executable flag upon initialization in loader-v4.

(cherry picked from commit 3bf9c2e)
@mergify mergify bot mentioned this pull request Nov 4, 2024
Open
@Lichtso Lichtso deleted the feature/remove_accounts_executable_flag_checks branch November 4, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoranYi HaoranYi HaoranYi approved these changes

Assignees
No one assigned
Labels
v2.1 Backport to v2.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lichtso @HaoranYi