Marks local-cluster tests with #[serial] #3466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
local-cluster tests timeout a lot; one is test_wait_for_max_stake(). All the local-cluster tests are marked with
#[serial]
to ensure they don't interfere with each other, but test_wait_for_max_stake() is not. We also see test failures in test_boot_from_local_state, which are due to timeouts too. Since#[serial]
is opt-in, if we do not add the annotation, the test can run concurrently with other tests.Summary of Changes
Mark all the local-cluster tests with #[serial].