increase minimum shred filtering distance #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #3295 for additional context.
Local cluster tests with multiple nodes that use very short (e.g. minimum/32 slot) epochs are subject to filtering out shreds that they actually need. This was observed as one of the causes of flakiness with
test_wait_for_max_stake.Summary of Changes
Add a floor to how low we can set the distance into the future at which we'll start filtering out shreds.
The current floor is effectively 64 given the minimum slots per epoch value we allow. With the chosen value of 500, this change will increase this ~an order of magnitude. It will effectively be a nop for any cluster running with >250 slots per epoch (e.g. mainnet/testnet/devnet)