v2.0: replay: do not refresh votes for hot spare validators (backport of #2770) #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 726a14f)
|
this reduces log spam observed on hotspares, no functional changes: |
|
seems unlikely that the downstream build failure is actually caused by this change. may need a rebase after some other fix though |
carllin
approved these changes
Aug 29, 2024
reran it and checks are now passing 🤷 |
t-nelson
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Hot spares will attempt to refresh votes even though the identity keypair check will fail.
This results in a large amount of log spam.
Summary of Changes
solana-labs#34737 (comment) creates a distinction between failed vote generation and non-voting validators.
Add an additional case for hot spare validators and exclude them from the refresh vote check as well.
Contributes to #2768
This is an automatic backport of pull request #2770 done by [Mergify](https://mergify.com).