Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot spares will attempt to refresh votes which creates log spam #2768

Open
AshwinSekar opened this issue Aug 28, 2024 · 0 comments
Open

Hot spares will attempt to refresh votes which creates log spam #2768

AshwinSekar opened this issue Aug 28, 2024 · 0 comments
Assignees

Comments

@AshwinSekar
Copy link

AshwinSekar commented Aug 28, 2024

Problem

Previous efforts:
solana-labs#32315
solana-labs#34737

Non voting validators (--no-voting) have no authorized voter keypairs which is correctly signaled not to refresh.
However hotspares will have an invalid identity keypair, this is not handled - still leads to GenerateVoteTxResult::Failed which will be eligble for refresh.

Proposed Solution

Add another case for hotspares to avoid refresh.
Also since authorized voter keypair and identity can be adjusted on the fly, allow for refresh if those are changed.

Example

This is hotspare from Pumpkin (https://discord.com/channels/428295358100013066/560174212967432193/1278376793455202418):

[2024-08-28T15:39:49.682690040Z WARN  solana_core::consensus] Trying to refresh timestamp for vote on 289850363
                         using smaller heaviest bank 289850363
[2024-08-28T15:39:49.682717395Z INFO  solana_core::replay_stage] Vote account node_pubkey mismatch: Poo1fGex6LzoVSn1kkQcvTamyK8J4FvKnEUeZhkd9Bv (expected: 5JjSDGpppMmmVo97ZFnMkDgCFhyrH4aU7ZBHPDmzcZAK).  Unable to vote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant