Don't attempt to refresh votes on non voting validators #32315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32315 +/- ##
=========================================
- Coverage 82.1% 82.0% -0.1%
=========================================
Files 773 773
Lines 209755 209765 +10
=========================================
- Hits 172225 172208 -17
- Misses 37530 37557 +27 |
steviez
reviewed
Jun 29, 2023
AshwinSekar
force-pushed
the
refresh-ts-fix
branch
from
7933df3
to
56ed837
Compare
steviez
reviewed
Jun 29, 2023
AshwinSekar
force-pushed
the
refresh-ts-fix
branch
from
56ed837
to
aeb451b
Compare
carllin
approved these changes
Jul 1, 2023
|
good catch! |
mergify bot
pushed a commit
that referenced
this pull request
Jul 1, 2023
(cherry picked from commit e1576b5) # Conflicts: # core/src/consensus/tower1_14_11.rs # core/src/replay_stage.rs
mergify bot
pushed a commit
that referenced
this pull request
Jul 1, 2023
(cherry picked from commit e1576b5) # Conflicts: # core/src/replay_stage.rs
This was referenced Jul 1, 2023
AshwinSekar
added a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit e1576b5) # Conflicts: # core/src/replay_stage.rs
AshwinSekar
added a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit e1576b5) # Conflicts: # core/src/replay_stage.rs
AshwinSekar
added a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit e1576b5) # Conflicts: # core/src/consensus/tower1_14_11.rs # core/src/replay_stage.rs
AshwinSekar
added a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit e1576b5) # Conflicts: # core/src/consensus/tower1_14_11.rs # core/src/replay_stage.rs
AshwinSekar
added a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit e1576b5) # Conflicts: # core/src/consensus/tower1_14_11.rs # core/src/replay_stage.rs
AshwinSekar
added a commit
that referenced
this pull request
Jul 8, 2023
…ort of #32315) (#32355) Don't attempt to refresh votes on non voting validators (#32315) (cherry picked from commit e1576b5) # Conflicts: # core/src/consensus/tower1_14_11.rs # core/src/replay_stage.rs Co-authored-by: Ashwin Sekar <ashwin@solana.com> Co-authored-by: Will Hickey <will.hickey@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Non voting validators or validators with unstaked identities in hotswap setups will never generate a tower blockhash, although they will continue adding votes to the tower.
The default blockhash is expired, so this will prompt these validators to attempt to refresh their vote. Although they can't vote anyway this will print an extra
WARNcluttering the log.Summary of Changes
Return early if blockhash is default.
Fixes #