v2.0: fix: borrow stakes delegation during snapshot serialization (backport of #2455) #2500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When serializing snapshots, we do a full deep clone of the stake delegations when serializing
Stakes<Delegation>
. As of v2.1 this serialization flow is limited to serializing the stakes cache since epoch stakes are serialized with versioned epoch stakes as of #2282.Summary of Changes
Build a shallow copy of stake delegations by borrowing the
delegation
field from the stake accounts to avoid allocating so much when serializingStakes<Delegation>
during snapshot creation.Fixes #
This is an automatic backport of pull request #2455 done by [Mergify](https://mergify.com).