feat: serialize new versioned epoch stakes bank snapshot field #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
reviewed
Jul 25, 2024
jstarry
force-pushed
the
feat/epoch-stakes-new
branch
from
567973f
to
bad8e8a
Compare
jstarry
force-pushed
the
feat/epoch-stakes-new
branch
from
42172c5
to
928ba9b
Compare
jstarry
force-pushed
the
feat/epoch-stakes-new
branch
from
1e4817a
to
c2a4346
Compare
brooksprumo
reviewed
Jul 29, 2024
jstarry
added
the
automerge
CriesofCarrots
approved these changes
Jul 29, 2024
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
jstarry
commented
Aug 6, 2024
| versioned_epoch_stakes.insert( | ||
| epoch, | ||
| VersionedEpochStakes::Current { | ||
| stakes: Stakes::<Stake>::from(stakes.clone()), |
There was a problem hiding this comment.
@brooksprumo as you pointed out, this is causing us to do a clone of all epoch stakes. I see a few workarounds:
- replace all of the bank epoch stakes entries with
StakesEnum::Stakeswhen we compute them for snapshots - when we save off bank epoch stakes during epoch boundaries, replace the
StakesEnum::AccountswithStakesEnum::Stakesimmediately - do the custom serialization approach we do for the
epoch_stakesfield where we keepStakesEnum::AccountsinVersionedEpochStakesbut when serializing, it gets serialized as aStakesEnum::Stakes
I'm going to explore the first one
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In v2.0, the solana protocol added support for deserializing the new versioned epoch stakes bank snapshot field. Now in v2.1 we can start serializing that new field.
Summary of Changes
Implements phase 2 of solana-foundation/solana-improvement-documents#149
versioned_epoch_stakesas a new serializable extra fieldFixes #