Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add langs_count option in Wakatime languages cart #988

Merged

Conversation

florianbussmann
Copy link
Contributor

This adds a parameter called langs_count for limiting the number of languages shown on wakatime cards and closes #968

image

Not providing langs_count defaults to all available languages

image

Limiting to 1 language

image

Limiting to 2 languages

image

Limiting MoonFoxy from the mentioned issue to 5 languages

image

@vercel
Copy link

vercel bot commented Apr 10, 2021

@florianbussmann is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the doc-translation README doc translations. label Apr 10, 2021
@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #988 (ea38f24) into master (f3c3950) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
+ Coverage   93.98%   94.00%   +0.01%     
==========================================
  Files          22       22              
  Lines         682      684       +2     
  Branches      191      192       +1     
==========================================
+ Hits          641      643       +2     
  Misses         37       37              
  Partials        4        4              
Impacted Files Coverage Δ
src/cards/wakatime-card.js 98.55% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c3950...ea38f24. Read the comment docs.

@anuraghazra
Copy link
Owner

Thanks @florianbussmann sorry for late. LGTM!

@anuraghazra anuraghazra merged commit 9773d92 into anuraghazra:master Apr 26, 2021
anuraghazra added a commit that referenced this pull request Apr 26, 2021
…ayed (#959)

* added a dark theme like the github dark theme

* fixed hide in top_languages interfering with number of languages displayed

* fixed hide in top_languages interfering with number of languages displayed

* fixed hide in top_languages interfering with number of languages displayed

* fixed misplaced function argument

* style(themes): Add GitHub dark theme (#758)

This styling falls in line with the recently released GitHub dark mode

Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>

* docs: add covid fund link (#1019)

* docs: add `npm install` step to CONTRIBUTING.md (#1015)

* fix: apply parseBoolean to hide_border in pin.js (#1014)

* feat: limit langs shown on wakatime card (#988)

* fix: fixed javascript oof moment

Co-authored-by: Issy <48881813+issy@users.noreply.github.com>
Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>
Co-authored-by: Mike Beaton <mjsbeaton@gmail.com>
Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de>
hypernova7 pushed a commit to hypernova7/github-readme-stats that referenced this pull request Apr 28, 2021
* docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015)

* fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014)

* feat: limit langs shown on wakatime card (anuraghazra#988)

* fix: hide in top_languages interfering with number of languages displayed (anuraghazra#959)

* added a dark theme like the github dark theme

* fixed hide in top_languages interfering with number of languages displayed

* fixed hide in top_languages interfering with number of languages displayed

* fixed hide in top_languages interfering with number of languages displayed

* fixed misplaced function argument

* style(themes): Add GitHub dark theme (anuraghazra#758)

This styling falls in line with the recently released GitHub dark mode

Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>

* docs: add covid fund link (anuraghazra#1019)

* docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015)

* fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014)

* feat: limit langs shown on wakatime card (anuraghazra#988)

* fix: fixed javascript oof moment

Co-authored-by: Issy <48881813+issy@users.noreply.github.com>
Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>
Co-authored-by: Mike Beaton <mjsbeaton@gmail.com>
Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de>

* fix: remove extra github dark theme

* docs: update readme_kr.md (anuraghazra#1007)

Correct typos

* feat: added border_color option (anuraghazra#1000)

* feat: Allow customization of border color

* docs: Update readme

Co-authored-by: Mike Beaton <mjsbeaton@gmail.com>
Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de>
Co-authored-by: Mohammed Mushahid Qureshi <mushahidq@gmail.com>
Co-authored-by: Issy <48881813+issy@users.noreply.github.com>
Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>
Co-authored-by: Jaime <lcalmsky@gmail.com>
Co-authored-by: Rishi Suresh <rishi9632@gmail.com>
hypernova7 pushed a commit to hypernova7/github-readme-stats that referenced this pull request Apr 28, 2021
* docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015)

* fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014)

* feat: limit langs shown on wakatime card (anuraghazra#988)

* fix: hide in top_languages interfering with number of languages displayed (anuraghazra#959)

* added a dark theme like the github dark theme

* fixed hide in top_languages interfering with number of languages displayed

* fixed hide in top_languages interfering with number of languages displayed

* fixed hide in top_languages interfering with number of languages displayed

* fixed misplaced function argument

* style(themes): Add GitHub dark theme (anuraghazra#758)

This styling falls in line with the recently released GitHub dark mode

Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>

* docs: add covid fund link (anuraghazra#1019)

* docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015)

* fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014)

* feat: limit langs shown on wakatime card (anuraghazra#988)

* fix: fixed javascript oof moment

Co-authored-by: Issy <48881813+issy@users.noreply.github.com>
Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>
Co-authored-by: Mike Beaton <mjsbeaton@gmail.com>
Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de>

* fix: remove extra github dark theme

* docs: update readme_kr.md (anuraghazra#1007)

Correct typos

* feat: added border_color option (anuraghazra#1000)

* feat: Allow customization of border color

* docs: Update readme

Co-authored-by: Mike Beaton <mjsbeaton@gmail.com>
Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de>
Co-authored-by: Mohammed Mushahid Qureshi <mushahidq@gmail.com>
Co-authored-by: Issy <48881813+issy@users.noreply.github.com>
Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>
Co-authored-by: Jaime <lcalmsky@gmail.com>
Co-authored-by: Rishi Suresh <rishi9632@gmail.com>
Kab1r pushed a commit to Kab1r/github-readme-stats that referenced this pull request Apr 4, 2022
Kab1r pushed a commit to Kab1r/github-readme-stats that referenced this pull request Apr 4, 2022
…ayed (anuraghazra#959)

* added a dark theme like the github dark theme

* fixed hide in top_languages interfering with number of languages displayed

* fixed hide in top_languages interfering with number of languages displayed

* fixed hide in top_languages interfering with number of languages displayed

* fixed misplaced function argument

* style(themes): Add GitHub dark theme (anuraghazra#758)

This styling falls in line with the recently released GitHub dark mode

Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>

* docs: add covid fund link (anuraghazra#1019)

* docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015)

* fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014)

* feat: limit langs shown on wakatime card (anuraghazra#988)

* fix: fixed javascript oof moment

Co-authored-by: Issy <48881813+issy@users.noreply.github.com>
Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com>
Co-authored-by: Mike Beaton <mjsbeaton@gmail.com>
Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-translation README doc translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add langs_count option in Wakatime languages cart
2 participants