fix: apply parseBoolean to hide_border in pin.js #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikebeaton is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 22 22
Lines 682 682
Branches 191 191
=======================================
Hits 641 641
Misses 37 37
Partials 4 4
Continue to review full report at Codecov.
|
|
Good catch @mikebeaton Thanks for the fix! |
anuraghazra
added a commit
that referenced
this pull request
Apr 26, 2021
…ayed (#959) * added a dark theme like the github dark theme * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed misplaced function argument * style(themes): Add GitHub dark theme (#758) This styling falls in line with the recently released GitHub dark mode Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> * docs: add covid fund link (#1019) * docs: add `npm install` step to CONTRIBUTING.md (#1015) * fix: apply parseBoolean to hide_border in pin.js (#1014) * feat: limit langs shown on wakatime card (#988) * fix: fixed javascript oof moment Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de>
hypernova7
pushed a commit
to hypernova7/github-readme-stats
that referenced
this pull request
Apr 28, 2021
* docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015) * fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014) * feat: limit langs shown on wakatime card (anuraghazra#988) * fix: hide in top_languages interfering with number of languages displayed (anuraghazra#959) * added a dark theme like the github dark theme * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed misplaced function argument * style(themes): Add GitHub dark theme (anuraghazra#758) This styling falls in line with the recently released GitHub dark mode Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> * docs: add covid fund link (anuraghazra#1019) * docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015) * fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014) * feat: limit langs shown on wakatime card (anuraghazra#988) * fix: fixed javascript oof moment Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de> * fix: remove extra github dark theme * docs: update readme_kr.md (anuraghazra#1007) Correct typos * feat: added border_color option (anuraghazra#1000) * feat: Allow customization of border color * docs: Update readme Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de> Co-authored-by: Mohammed Mushahid Qureshi <mushahidq@gmail.com> Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Jaime <lcalmsky@gmail.com> Co-authored-by: Rishi Suresh <rishi9632@gmail.com>
hypernova7
pushed a commit
to hypernova7/github-readme-stats
that referenced
this pull request
Apr 28, 2021
* docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015) * fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014) * feat: limit langs shown on wakatime card (anuraghazra#988) * fix: hide in top_languages interfering with number of languages displayed (anuraghazra#959) * added a dark theme like the github dark theme * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed misplaced function argument * style(themes): Add GitHub dark theme (anuraghazra#758) This styling falls in line with the recently released GitHub dark mode Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> * docs: add covid fund link (anuraghazra#1019) * docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015) * fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014) * feat: limit langs shown on wakatime card (anuraghazra#988) * fix: fixed javascript oof moment Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de> * fix: remove extra github dark theme * docs: update readme_kr.md (anuraghazra#1007) Correct typos * feat: added border_color option (anuraghazra#1000) * feat: Allow customization of border color * docs: Update readme Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de> Co-authored-by: Mohammed Mushahid Qureshi <mushahidq@gmail.com> Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Jaime <lcalmsky@gmail.com> Co-authored-by: Rishi Suresh <rishi9632@gmail.com>
Kab1r
pushed a commit
to Kab1r/github-readme-stats
that referenced
this pull request
Apr 4, 2022
Kab1r
pushed a commit
to Kab1r/github-readme-stats
that referenced
this pull request
Apr 4, 2022
…ayed (anuraghazra#959) * added a dark theme like the github dark theme * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed misplaced function argument * style(themes): Add GitHub dark theme (anuraghazra#758) This styling falls in line with the recently released GitHub dark mode Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> * docs: add covid fund link (anuraghazra#1019) * docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015) * fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014) * feat: limit langs shown on wakatime card (anuraghazra#988) * fix: fixed javascript oof moment Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1011 - Think this is fairly straight-forward and non-controversial. Also tested, and works as required with this change. Thanks. (And thanks for a great project! 😊)