-
-
Notifications
You must be signed in to change notification settings - Fork 22.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply parseBoolean to hide_border in pin.js #1014
Conversation
@mikebeaton is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 22 22
Lines 682 682
Branches 191 191
=======================================
Hits 641 641
Misses 37 37
Partials 4 4
Continue to review full report at Codecov.
|
Good catch @mikebeaton Thanks for the fix! |
…ayed (#959) * added a dark theme like the github dark theme * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed misplaced function argument * style(themes): Add GitHub dark theme (#758) This styling falls in line with the recently released GitHub dark mode Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> * docs: add covid fund link (#1019) * docs: add `npm install` step to CONTRIBUTING.md (#1015) * fix: apply parseBoolean to hide_border in pin.js (#1014) * feat: limit langs shown on wakatime card (#988) * fix: fixed javascript oof moment Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de>
* docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015) * fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014) * feat: limit langs shown on wakatime card (anuraghazra#988) * fix: hide in top_languages interfering with number of languages displayed (anuraghazra#959) * added a dark theme like the github dark theme * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed misplaced function argument * style(themes): Add GitHub dark theme (anuraghazra#758) This styling falls in line with the recently released GitHub dark mode Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> * docs: add covid fund link (anuraghazra#1019) * docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015) * fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014) * feat: limit langs shown on wakatime card (anuraghazra#988) * fix: fixed javascript oof moment Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de> * fix: remove extra github dark theme * docs: update readme_kr.md (anuraghazra#1007) Correct typos * feat: added border_color option (anuraghazra#1000) * feat: Allow customization of border color * docs: Update readme Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de> Co-authored-by: Mohammed Mushahid Qureshi <mushahidq@gmail.com> Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Jaime <lcalmsky@gmail.com> Co-authored-by: Rishi Suresh <rishi9632@gmail.com>
* docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015) * fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014) * feat: limit langs shown on wakatime card (anuraghazra#988) * fix: hide in top_languages interfering with number of languages displayed (anuraghazra#959) * added a dark theme like the github dark theme * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed misplaced function argument * style(themes): Add GitHub dark theme (anuraghazra#758) This styling falls in line with the recently released GitHub dark mode Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> * docs: add covid fund link (anuraghazra#1019) * docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015) * fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014) * feat: limit langs shown on wakatime card (anuraghazra#988) * fix: fixed javascript oof moment Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de> * fix: remove extra github dark theme * docs: update readme_kr.md (anuraghazra#1007) Correct typos * feat: added border_color option (anuraghazra#1000) * feat: Allow customization of border color * docs: Update readme Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de> Co-authored-by: Mohammed Mushahid Qureshi <mushahidq@gmail.com> Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Jaime <lcalmsky@gmail.com> Co-authored-by: Rishi Suresh <rishi9632@gmail.com>
…ayed (anuraghazra#959) * added a dark theme like the github dark theme * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed hide in top_languages interfering with number of languages displayed * fixed misplaced function argument * style(themes): Add GitHub dark theme (anuraghazra#758) This styling falls in line with the recently released GitHub dark mode Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> * docs: add covid fund link (anuraghazra#1019) * docs: add `npm install` step to CONTRIBUTING.md (anuraghazra#1015) * fix: apply parseBoolean to hide_border in pin.js (anuraghazra#1014) * feat: limit langs shown on wakatime card (anuraghazra#988) * fix: fixed javascript oof moment Co-authored-by: Issy <48881813+issy@users.noreply.github.com> Co-authored-by: Anurag Hazra <hazru.anurag@gmail.com> Co-authored-by: Mike Beaton <mjsbeaton@gmail.com> Co-authored-by: Florian Bussmann <hallo@florian-bussmann.de>
Fixes #1011 - Think this is fairly straight-forward and non-controversial. Also tested, and works as required with this change. Thanks. (And thanks for a great project! 😊)