-
Notifications
You must be signed in to change notification settings - Fork 224
fix: multiple canvas rendering errors #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: de5a6de The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @wang1212, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves critical rendering issues that arose in multi-canvas environments due to improper global state management. It refactors the internal state handling mechanism by associating mutation records directly with individual canvas elements rather than a shared global service, ensuring isolated and correct rendering behavior across multiple canvas instances. Additionally, the PR includes updates to test case naming conventions and introduces a new comprehensive demo for the HTML rendering plugin. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses a bug causing rendering errors in multi-canvas scenarios by refactoring state management from a global singleton to per-element instances. The core logic changes in SceneGraphService are sound and directly solve the described problem. The accompanying updates to test files, including renaming for clarity and adding a new comprehensive test case for the HTML renderer, are also good additions. I have one suggestion to improve the robustness of the new mutation handling logic for future extensions.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
In #2031, during the code refactoring process, the state related to the canvas instance was maintained in a global singleton, which caused rendering errors in scenarios with multiple canvas instances.
Now, state is maintained on the element instance to avoid state chaos between multiple canvas instances.
📝 Changelog
☑️ Self Check before Merge