-
Notifications
You must be signed in to change notification settings - Fork 224
perf: remove rBush logic from element picking mechanism #2031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f228414 The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully removes the rBush spatial indexing logic for element picking to improve performance, replacing it with a scene graph traversal. This change simplifies the codebase, particularly within the PrepareRendererPlugin. The introduction of a new test suite for element picking is a great addition to ensure the new implementation is correct and performant. My review includes a couple of suggestions: removing some leftover debugging logs in the new tests and considering an iterative approach for the scene graph traversal to enhance robustness against very deep hierarchies.
* feat(benchmark): Add performance test suite and analysis panel (#1987) * fix: docs dead links (#1984) * fix: docs dead links * fix: add /en prefix to english docs * feat: upgrade chrome extension to manifest v3 and react to v18 - Upgrade manifest version from v2 to v3 with updated permissions format - Migrate background scripts to service worker - Update content_security_policy and web_accessible_resources format - Replace browser_action with action - Upgrade react and react-dom from v16 to v18 in g-devtool - Update devtool UI to support React 18 createRoot API - Maintain backward compatibility with legacy versions - Update minimum chrome version requirement to 88 * feat: add GitHub workflow for bug report reproduction check - Add new GitHub Actions workflow 'bug-report-reproduction-check' - Automatically analyze new bug reports for reproduction steps - Use Mistral AI to check for complete reproduction information - Add friendly comment when reproduction details are missing - Only trigger for issues labeled as 'bug' - Add necessary permissions for issues and models access * feat: add benchmark suite for rendering performance comparison - Add benchmark infrastructure with TestCase and TestRunner base classes - Implement test cases for basic shapes (circle, rect, path, etc.) across multiple renderers - Support g-canvas, g-canvas-v4 and zrender rendering engines - Add UI components for test execution and result visualization - Include i18n support with Chinese and English translations - Set up build configuration with Vite and TypeScript * feat(benchmark): add collapsible insight panel in PerformanceChart - Add state to track insight panel expansion - Implement collapsible UI with smooth animations - Improve styling and layout of insight panel - Add expand/collapse toggle functionality - Enhance user experience with better visual feedback * chore(benchmark): add performance test results for basic shapes Add benchmark results for basic shapes rendering comparison between different engines including g-canvas and zrender. The results include execution duration and memory usage metrics. * feat(benchmark): enhance i18n support for failure rate display - Add new translation key 'highestFailureRate' for displaying failure rate in both English and Chinese - Refactor failure rate display to use i18n template - Improve code formatting in PerformanceChart component - Fix whitespace and indentation issues in TestRunner * chore: remove other file * feat: Add native pan and zoom demo (#1994) * feat: add native pan and zoom demo Adds a new demo under `__tests__/demos/camera/` that showcases how to implement panning and zooming on the canvas using native DOM events. This is in response to the user request to add such a demo. An issue in the execution environment prevented the test suite from being run. A `commitlint` hook blocked all commands, including `pnpm test`. The changes are submitted without test verification due to this environmental constraint. * fix: use getContextService for container access in nativePanZoom demo --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: wang1212 <mrwang1212@126.com> * feat: add script to fetch and display npm download stats for monorepo packages * chore: update test config and TypeScript settings - Add JSDoc link to jest.unit.config.js - Fix module name mapper path in jest.unit.config.js - Expand coverage collection to more packages - Update coverage reporters - Move isolatedModules to tsconfig.json * fix: fix loop index in tapable (#2003) * fix: fix loop index in SyncWaterfallHook and AsyncSeriesWaterfallHook - Fix loop index in SyncWaterfallHook to start from 1 instead of 0 since the first callback is already called - Apply the same fix to AsyncSeriesWaterfallHook for consistency - Add comprehensive unit tests for all tapable hook types * chore: fix code style * chore: fix code lint issue * chore: add changeset * Add basic shape benchmark cases for g-canvas-local engine (#2030) * test: Add basic shape benchmark cases for g-canvas-local engine * test: Add basic shape benchmark cases for g-canvas-local engine * Update benchmark/src/benchmarks/g-canvas-local/engine.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * feat(text): add text-decoration support for text elements (#2035) * feat(text): add text-decoration support for text elements * docs: update text decoration info * docs: fix typos * perf: element event batch triggering (#2005) * perf: element event batch triggering * chore: update test snapshot * chore: use Array.from to convert iterator for compatibility * chore: add changeset * Update __tests__/demos/perf/custom-event.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * perf: remove rBush logic from element picking mechanism (#2031) * perf: remove rBush logic from element picking mechanism * chore: fix lint error * chore: add changeset * chore: update test case * fix: the element picking range includes the element border * chore(release): bump version (#2004) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * perf(g-plugin-canvas-renderer): improve wavy text decoration with quadratic curves * Update __tests__/demos/event/hit-test.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
In the past, the process of element picking mechanism required 3 steps:
Although spatial index queries can quickly filter out a large number of elements, the cost is that we need to fully update the index data for each frame. This process has been proven to have a serious impact on performance in existing business scenarios.
On the other hand, based on existing graphics engine implementations in the industry, spatial index queries increase logical complexity and may also cause performance issues, so it is not a recommended optimization method.
Before:
Now:
What else can be done:
📝 Changelog
☑️ Self Check before Merge