Add e2e test for the NodeLatencyMonitor feature #6612

Rupam-It · 2024-08-18T18:05:10Z

This PR adds end-to-end (e2e) tests for the NodeLatencyMonitor feature, which is currently available in Alpha as part of Antrea v2.1 (#6120).

Fixes #6549.

antoninbas

All e2e tests go under test/e2e and are written in a specific way - you could say we have a "framework" that we use for all our e2e tests. Please refer to that folder for examples. There are a lot of test files you can look at, such as test/e2e/basic_test.go.

Rupam-It

Refactored e2e Tests: Updated the e2e tests to align with the framework established in the test/e2e directory. I’ve restructured the tests to match the format used in test/e2e/basic_test.go, ensuring consistency across our test suite. These changes should address your feedback and improve alignment with our testing standards. Thanks for your guidance, @antoninbas .

antoninbas

The proposed e2e tests are not actually testing anything. You are just validating CRUD operations on the NodeLatencyMonitor CRD. These CRUD operations are provided by K8s, not Antrea, so in essence you are testing CRD support in K8s, and not testing the NodeLatencyMonitor feature in Antrea.
The issue for this task (#6549) describes what operations the e2e tests should cover.

antoninbas · 2024-08-20T17:21:41Z

test/e2e/nodelatencymonitor_test.go

+// GetKubeconfigPath returns the path to the kubeconfig file used for connecting to the Kubernetes cluster.
+func GetKubeconfigPath() (string, error) {
+	// Check if the KUBECONFIG environment variable is set
+	kubeconfig := os.Getenv("KUBECONFIG")
+	if kubeconfig == "" {
+		// Default to the kubeconfig path in the user's home directory if not set
+		kubeconfig = filepath.Join(os.Getenv("HOME"), ".kube", "config")
+	}
+
+	// Verify that the kubeconfig file exists
+	if _, err := os.Stat(kubeconfig); os.IsNotExist(err) {
+		return "", fmt.Errorf("kubeconfig file does not exist at path: %s", kubeconfig)
+	}
+
+	return kubeconfig, nil
+}
+
+// getAntreaClient returns a clientset for interacting with Antrea CRDs
+func getAntreaClient(t *testing.T) *clientset.Clientset {
+	kubeconfig, err := GetKubeconfigPath()
+	failOnError(err, t)
+
+	config, err := clientcmd.BuildConfigFromFlags("", kubeconfig)
+	failOnError(err, t)
+
+	antreaClientset, err := clientset.NewForConfig(config)
+	failOnError(err, t)
+	return antreaClientset
+}


Please refer to other e2e tests. The framework already provides access to clientsets for K8s / Antrea, and there is no need for these 2 functions.

okk, I understand. I'm doiing.

Hii @antoninbas i'm so close towards my goal but
getting this error in test file
nodelatencymonitor_test.go:143: Failed to retrieve NodeLatencyStats: the server could not find the requested resource (get nodelatencystats.crd.antrea.io)
also
kubectl get nodelatencystats
error: the server doesn't have a resource type "nodelatencystats"

is there any thing i have missed?

nodelatencystats.crd.antrea.io does not exist as NodeLatencyStats is not a CRD

kubectl get nodelatencystats should work fine unless you are using an older version of Antrea (prior to v2.1). You should be testing against the "latest" Antrea (main branch).

When running kubectl api-resources, you should see the following:

... antreaclusternetworkpolicystats stats.antrea.io/v1alpha1 false AntreaClusterNetworkPolicyStats antreanetworkpolicystats stats.antrea.io/v1alpha1 true AntreaNetworkPolicyStats multicastgroups stats.antrea.io/v1alpha1 false MulticastGroup networkpolicystats stats.antrea.io/v1alpha1 true NetworkPolicyStats nodelatencystats stats.antrea.io/v1alpha1 false NodeLatencyStats ...

Rupam-It

@antoninbas following the previous feedback, i have refactored the e2e test for nodelatencymonitor
feature to focus on functional testing of Antrea .

Validate the correct enabling and disabling of latency probes.
Ensure the PingIntervalSeconds is respected and updated as expected.
Check that latency stats are accurately recorded and retrieved, aligning with the intended behavior of the NodeLatencyMonitor feature in Antrea.

I think it will meet the necessary requirements.

antoninbas · 2024-08-26T17:49:11Z

test/e2e/nodelatencymonitor_test.go

+	nlm := &v1alpha1.NodeLatencyMonitor{
+		ObjectMeta: v1.ObjectMeta{
+			Name:      nodeLatencyMonitorName,
+			Namespace: nodeLatencyMonitorNS,


It's a cluster-scoped CRD, there should be no namespace

antoninbas · 2024-08-26T17:50:48Z

test/e2e/nodelatencymonitor_test.go

+)
+
+func TestNodeLatencyMonitor(t *testing.T) {
+	skipIfNotRequired(t)


I am not sure why you included this? With a single argument, I believe this is a no-op

however, the test should be skipped if the feature (NodeLatencyMonitor) is disabled. We have the skipIfFeatureDisabled helper function for this.

antoninbas · 2024-08-26T17:52:20Z

test/e2e/nodelatencymonitor_test.go

+
+	data, err := setupTest(t)
+	if err != nil {
+		t.Fatalf("Failed to set up clients: %v", err)


the error message doesn't seem accurate

antoninbas · 2024-08-26T17:55:29Z

test/e2e/nodelatencymonitor_test.go

+		t.Fatalf("Failed to delete NodeLatencyMonitor CR: %v", err)
+	}
+
+	waitForLatencyProbesDisabled(t, data)


does this really serve a purpose? The resource has no finalizers, so it should be deleted immediately, and I think there is no point in querying the API again to check for deletion. Is that no what you observed?

antoninbas · 2024-08-26T17:55:48Z

test/e2e/nodelatencymonitor_test.go

+func testEnableLatencyProbes(t *testing.T, data *TestData) {
+	waitForLatencyProbesEnabled(t, data)
+}


I am not sure what the point of this test is?

antoninbas · 2024-08-26T17:56:09Z

test/e2e/nodelatencymonitor_test.go

+	t.Run("testEnableLatencyProbes", func(t *testing.T) {
+		testEnableLatencyProbes(t, data)
+	})
+	t.Run("testRetrieveLatencyStats", func(t *testing.T) {
+		testRetrieveLatencyStats(t, data)
+	})
+	t.Run("testUpdatePingInterval", func(t *testing.T) {
+		testUpdatePingInterval(t, data)
+	})
+	t.Run("testDisableLatencyProbes", func(t *testing.T) {
+		testDisableLatencyProbes(t, data)
+	})


it's better if subtests are independent and don't assume a specific execution order

Rupam-It

@antoninbas i have made your desire changes .
I've run the sub tests independently, they works fine.

antoninbas · 2024-08-28T17:28:16Z

test/e2e/nodelatencymonitor_test.go

+func generatePingInterval() int32 {
+	return int32(rand.Intn(21) + 30)
+}


there is no reason to use a random value for the ping interval

antoninbas · 2024-08-28T17:29:24Z

test/e2e/nodelatencymonitor_test.go

+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"k8s.io/apimachinery/pkg/api/errors"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"


Renaming the import to v1 here has no effect as it is already the default name. I suggest renaming it to metav1 instead, which is what we usually do.

antoninbas · 2024-08-28T17:29:49Z

test/e2e/nodelatencymonitor_test.go

+	"testing"
+	"time"
+
+	v1alpha1 "antrea.io/antrea/pkg/apis/crd/v1alpha1"


Renaming the import to v1alpha1 here has no effect as it is already the default name. I suggest renaming it to crdv1alpha1 instead, which is what we usually do.

antoninbas · 2024-08-28T17:30:06Z

test/e2e/nodelatencymonitor_test.go

+}
+
+func TestNodeLatencyMonitor(t *testing.T) {
+


no need for an empty line here

test/e2e/nodelatencymonitor_test.go

antoninbas · 2024-08-28T17:35:16Z

test/e2e/nodelatencymonitor_test.go

+
+	ctx := context.Background()
+
+	_, err := data.crdClient.StatsV1alpha1().NodeLatencyStats().Create(ctx, summary, v1.CreateOptions{})


there is a misunderstanding here. It is Antrea that should create the NodeLatencyStats object as a result of enabling the NodeLatencyMonitor functionality. The test case should not be creating it.

yes, i have some confusion here.
can you provide me documentation of it

Documentation for the feature is available here: https://github.com/antrea-io/antrea/blob/main/docs/feature-gates.md#nodelatencymonitor

The NodeLatencyMonitor CRD is to enable ICMP probes, which will measure latency between pairs of Nodes. The latency measurements are then reported by Antrea through the NodeLatencyStats API. The e2e test should validate that when enabling NodeLatencyMonitor, invoking the NodeLatencyStats API (GET) returns appropriate measurements.

One thing to clarify,
My implementation is almost right other than the nodeLatencyStats creation part?

Or the whole function is wrong ?

antoninbas · 2024-08-28T17:37:47Z

test/e2e/nodelatencymonitor_test.go

+	}
+}
+
+func testEnableLatencyProbes(t *testing.T, data *TestData) {


This test does not do anything. It just creates the CR (which only involves the K8s API), and it does not check that NodeLatencyStats are reported correctly.

I would recommend having a single test case in this PR, which will

create the CR, with a ping interval of 10s

poll until NodeLatencyStats are reported correctly

delete the CR

We can improve testing over time.

so, as the flow of test case

create the CR, with a ping interval of 10s

delete the CR
this are implemented

poll until NodeLatencyStats are reported correctly
functionality i have do to correction.

update ping Interval will be deleted from here..
right?

You have inverted steps 2 and 3

update ping Interval will be deleted from here..

yes, and you should only have one test, not 4

Rupam-It

hi @antoninbas , this changes in test surely match with requirements.

antoninbas · 2024-08-29T17:13:50Z

test/e2e/nodelatencymonitor_test.go

+	t.Logf("NodeLatencyMonitor CR created successfully.")
+
+	//  2: Poll until(5min) NodeLatencyStats are reported correctly
+	ctx := context.Background()


why use context.Background() here when you use context.TODO() for other API calls?

antoninbas · 2024-08-29T17:19:33Z

test/e2e/nodelatencymonitor_test.go

+
+	//  2: Poll until(5min) NodeLatencyStats are reported correctly
+	ctx := context.Background()
+	err = wait.PollImmediate(time.Second, 300*time.Second, func() (bool, error) {


I am not sure what kind of checks you are doing in the condition function. You are computing max latency and average latency, but then you just log them? This is the test so it should validate the contents of the NodeLatencyStats objects to make sure they are correct.

I would suggest the following:

a first call to wait.PollImmediate, with a 30s timeout (after all the ping interval is set to 10s). This should validate that the NodeLatencyStats objects are available. There should be one per Node, and for each one, there should be one entry in PeerNodeLatencyStats for each Node. You can also make sure that TargetIPLatencyStats has the correct size (1 if cluster is IPv4-only or IPv6-only, 2 if cluster is dual-stack, and that each latency number is strictly positive.

a second call to wait.PollImmediate, again with a 30s timeout, which validates that the stats are refreshed after some time. You should perform the same validations as for the first call to wait.PollImmediate, but also check that all the LastSendTime and LastRecvTime fields have been updated.

Rupam-It

@antoninbas i've done the recommended changes.

antoninbas · 2024-08-29T19:04:02Z

test/e2e/nodelatencymonitor_test.go

+			return false, err
+		}
+
+		if len(statsList.Items) == 0 {


the length should match the number of Nodes in the cluster

antoninbas · 2024-08-29T19:04:12Z

test/e2e/nodelatencymonitor_test.go

+		}
+
+		for _, item := range statsList.Items {
+			if len(item.PeerNodeLatencyStats) == 0 {


ditto, the length should match the number of Nodes in the cluster

antoninbas · 2024-08-29T19:04:59Z

test/e2e/nodelatencymonitor_test.go

+				return false, nil
+			}
+			for _, peerStat := range item.PeerNodeLatencyStats {
+				if len(peerStat.TargetIPLatencyStats) == 0 {


please read #6612 (comment) again, the expected length depends on the type of cluster

antoninbas · 2024-08-29T19:05:42Z

test/e2e/nodelatencymonitor_test.go

+				}
+				for _, targetStat := range peerStat.TargetIPLatencyStats {
+					if targetStat.LastMeasuredRTTNanoseconds <= 0 {
+						t.Logf("Invalid(negetive) RTT for peer %s on node %s", peerStat.NodeName, item.Name)


Suggested change

t.Logf("Invalid(negetive) RTT for peer %s on node %s", peerStat.NodeName, item.Name)

t.Logf("Invalid RTT for peer %s reported by Node %s", peerStat.NodeName, item.Name)

test/e2e/nodelatencymonitor_test.go

antoninbas · 2024-08-29T19:07:35Z

test/e2e/nodelatencymonitor_test.go

+					previousSendTime = targetStat.LastSendTime
+					previousRecvTime = targetStat.LastRecvTime


The "previous" values must come from the previous poll. We need a previous value for each pair of Node, so you will need a map for this.

Rupam-It

@antoninbas I've refine the nodelatencystats test.

antoninbas

Overall the structure of the test looks good now, so all the new comments are suggestions for smaller improvements

antoninbas · 2024-08-30T18:14:44Z

test/e2e/nodelatencymonitor_test.go

+	nodes, err := data.clientset.CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{})
+	require.NoError(t, err, "Failed to list nodes")
+
+	var isDualStack bool
+	for _, node := range nodes.Items {
+		if node.Spec.PodCIDR != "" && strings.Contains(node.Spec.PodCIDR, ":") {
+			isDualStack = true
+			break
+		}
+	}


you should be using clusterInfo.podV4NetworkCIDR and clusterInfo.podV4NetworkCIDR to determine this

we already have a framework that performs the correct checks for you

antoninbas · 2024-08-30T18:15:19Z

test/e2e/nodelatencymonitor_test.go

+	t.Logf("NodeLatencyMonitor CR created successfully.")
+
+	validateNodeLatencyStats := func(statsList *v1alpha1.NodeLatencyStatsList, initialPoll bool, previousTimes map[string]map[string]metav1.Time) (bool, error) {
+		if len(statsList.Items) != len(nodes.Items) {


clusterInfo.numNodes stores the number of Nodes, it is populated by the framework

antoninbas · 2024-08-30T18:16:58Z

test/e2e/nodelatencymonitor_test.go

+	require.NoError(t, err, "Failed to create NodeLatencyMonitor CR")
+	t.Logf("NodeLatencyMonitor CR created successfully.")
+
+	validateNodeLatencyStats := func(statsList *v1alpha1.NodeLatencyStatsList, initialPoll bool, previousTimes map[string]map[string]metav1.Time) (bool, error) {


Move the previousTimes map declaration before the closure definition, and remove the previousTimes parameter

antoninbas · 2024-08-30T18:17:32Z

test/e2e/nodelatencymonitor_test.go

+
+		for _, item := range statsList.Items {
+			if len(item.PeerNodeLatencyStats) != len(nodes.Items)-1 {
+				t.Logf("Expected %d PeerNodeLatencyStats for node %s, but found %d, retrying...", len(nodes.Items), item.Name, len(item.PeerNodeLatencyStats))


invalid log message, the expected number of len(nodes.Items)-1, not len(nodes.Items)

antoninbas · 2024-08-30T18:17:49Z

test/e2e/nodelatencymonitor_test.go

+
+		for _, item := range statsList.Items {
+			if len(item.PeerNodeLatencyStats) != len(nodes.Items)-1 {
+				t.Logf("Expected %d PeerNodeLatencyStats for node %s, but found %d, retrying...", len(nodes.Items), item.Name, len(item.PeerNodeLatencyStats))


nit: in Antrea we capitalize all K8s terms (such as Node) in comments and log messages

antoninbas · 2024-08-30T18:21:07Z

test/e2e/nodelatencymonitor_test.go

+						previousTimes[item.Name][peerStat.NodeName] = targetStat.LastSendTime
+					} else {
+						previousSendTime, sendTimeExists := previousTimes[item.Name][peerStat.NodeName]
+						if !sendTimeExists || previousSendTime.Equal(&targetStat.LastSendTime) {


nit: for the check, I think it would be slightly better to validate that targetStat.LastSendTime > previousSendTime

antoninbas · 2024-08-30T18:21:56Z

test/e2e/nodelatencymonitor_test.go

+			return false, err
+		}
+
+		if len(statsList.Items) == 0 {


this seems redundant, given the checks already in validateNodeLatencyStats, so maybe we could remove it?

antoninbas · 2024-08-30T18:22:08Z

test/e2e/nodelatencymonitor_test.go

+			return false, err
+		}
+
+		if len(statsList.Items) == 0 {


antoninbas · 2024-08-30T18:22:27Z

test/e2e/nodelatencymonitor_test.go

+	err = wait.PollImmediate(time.Second, 30*time.Second, func() (bool, error) {
+		statsList, err := data.crdClient.StatsV1alpha1().NodeLatencyStats().List(context.TODO(), metav1.ListOptions{})
+		if err != nil {
+			t.Logf("Error while listing NodeLatencyStats: %v", err)


no need for this log message

antoninbas · 2024-08-30T18:22:32Z

test/e2e/nodelatencymonitor_test.go

+	err = wait.PollImmediate(time.Second, 30*time.Second, func() (bool, error) {
+		statsList, err := data.crdClient.StatsV1alpha1().NodeLatencyStats().List(context.TODO(), metav1.ListOptions{})
+		if err != nil {
+			t.Logf("Error while listing NodeLatencyStats: %v", err)


Rupam-It

@antoninbas I've removed the redundant codes & implements Antrea framework more efficiently.

antoninbas · 2024-09-03T16:59:49Z

test/e2e/nodelatencymonitor_test.go

+		valid, validateErr := validateNodeLatencyStats(statsList, true)
+		if !valid {
+			return false, validateErr
+		}
+		return true, nil


replace these 5 lines with return validateNodeLatencyStats(statsList, true)

antoninbas · 2024-09-03T16:59:57Z

test/e2e/nodelatencymonitor_test.go

+		valid, validateErr := validateNodeLatencyStats(statsList, false)
+		if !valid {
+			return false, validateErr
+		}
+		return true, nil


replace these 5 lines with return validateNodeLatencyStats(statsList, false)

test/e2e/nodelatencymonitor_test.go

antoninbas · 2024-09-03T17:02:07Z

test/e2e/nodelatencymonitor_test.go

+	err = data.crdClient.CrdV1alpha1().NodeLatencyMonitors().Delete(context.TODO(), "default", metav1.DeleteOptions{})
+	require.NoError(t, err, "Failed to delete NodeLatencyMonitor CR")
+	t.Logf("NodeLatencyMonitor CR deleted successfully.")


I just realized that this should be a defer statement just after the Create operation succeeds. Otherwise the test may fail (e.g., during one of the poll) and then the CR will not be deleted and will persist after the test case.

yes , you are right .
I'm changing.

Rupam-It

@antoninbas I have added he defer function that will surely delete nodeltancymonitor cr(if created) after test fail or success

antoninbas · 2024-09-03T18:02:25Z

@Rupam-It The DCO check is failing because at least one of your commits is not signed. This may be a good opportunity to squash all your commits and sign the one resulting commit.

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

… tests for NodeLatencyMonitor resources to ensure better clarity and functionality. Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

…me work Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Co-authored-by: Antonin Bas <antonin.bas@gmail.com> Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Rupam-It · 2024-09-03T18:44:24Z

@antoninbas Thank you so much for your patience and guidance throughout this process. Can you suggest me next issue to work on ?

antoninbas · 2024-09-04T20:17:44Z

@Rupam-It a few CI checks are failing:

the new file is missing a copyright header
the code linting tool is reporting some issues (you can run make golangci locally to check the issues and confirm that you have fixed them)

Rupam-It · 2024-09-05T15:11:28Z

Okk, I'm doing

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Rupam-It · 2024-09-06T10:09:50Z

hey @antoninbas i have add the copywrite headers also change in code that passes CI checks .

antoninbas · 2024-09-06T16:58:59Z

test/e2e/nodelatencymonitor_test.go

 package e2e

 import (
+	// Standard library imports


this is not a helpful comment, please remove it

antoninbas · 2024-09-06T16:59:08Z

test/e2e/nodelatencymonitor_test.go

@@ -1,16 +1,32 @@
+// Copyright 2020 Antrea Authors


the date is wrong

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Rupam-It · 2024-09-06T17:47:45Z

I think this changes will works fine .

antoninbas · 2024-09-06T18:17:32Z

/test-e2e

antoninbas

LGTM - thank you for your contribution @Rupam-It !

antoninbas · 2024-09-06T22:38:07Z

/skip-conformance
/skip-networkpolicy

Rupam-It · 2024-09-07T05:46:57Z

@antoninbas Thank you for your continuous guidance and patience throughout the process. I truly appreciate your support !
see you in next issue.

Rupam-It force-pushed the add-node-latency-monitor-tests branch from 947491a to d3c1f7b Compare August 19, 2024 04:04

antoninbas requested changes Aug 19, 2024

View reviewed changes

Rupam-It commented Aug 20, 2024

View reviewed changes

antoninbas reviewed Aug 20, 2024

View reviewed changes

Rupam-It commented Aug 25, 2024

View reviewed changes

antoninbas reviewed Aug 26, 2024

View reviewed changes

Rupam-It force-pushed the add-node-latency-monitor-tests branch 2 times, most recently from 204c0cb to 58f8ad0 Compare August 28, 2024 09:47

Rupam-It commented Aug 28, 2024

View reviewed changes

antoninbas reviewed Aug 28, 2024

View reviewed changes

Rupam-It force-pushed the add-node-latency-monitor-tests branch from 3e765c9 to 321dbdc Compare August 29, 2024 09:27

Rupam-It commented Aug 29, 2024

View reviewed changes

antoninbas reviewed Aug 29, 2024

View reviewed changes

Rupam-It commented Aug 29, 2024

View reviewed changes

antoninbas reviewed Aug 29, 2024

View reviewed changes

Rupam-It commented Aug 30, 2024

View reviewed changes

antoninbas reviewed Aug 30, 2024

View reviewed changes

Rupam-It commented Sep 1, 2024

View reviewed changes

antoninbas reviewed Sep 3, 2024

View reviewed changes

antoninbas changed the title ~~test: Add e2e Tests for NodeLatencyMonitor Feature title~~ Add e2e test for the NodeLatencyMonitor feature Sep 3, 2024

Rupam-It commented Sep 3, 2024

View reviewed changes

Rupam-It and others added 8 commits September 4, 2024 00:11

Added e2e tests for NodeLatencyMonitor

c96dcde

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

This commit addresses feedback from the PR review and refines the e2e…

d0affe0

… tests for NodeLatencyMonitor resources to ensure better clarity and functionality. Signed-off-by: Rupam-It <mannarupam3@gmail.com>

nodelatencymonitor_test.go file is shifted to test/e2e directory

4e3685d

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Add NodeLatencyMonitor tests

06ab884

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Updated e2e tests for NodeLatencyMonitor

9d7f653

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

making single test case

4a750b7

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

NodeLatencyStats objects to make sure they are correct.

1b8fd8a

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

refine nodelatencystats test

e9a8889

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Rupam-It and others added 4 commits September 4, 2024 00:11

remove redundancy of codes & updates that more specific to Antrea fra…

8d0f799

…me work Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Update test/e2e/nodelatencymonitor_test.go

639aa6b

Co-authored-by: Antonin Bas <antonin.bas@gmail.com> Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Update test/e2e/nodelatencymonitor_test.go

09f8471

Co-authored-by: Antonin Bas <antonin.bas@gmail.com> Signed-off-by: Rupam-It <mannarupam3@gmail.com>

add defer function for mandatorily delete the nodelatencymonitor CR

3b0d16f

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

Rupam-It force-pushed the add-node-latency-monitor-tests branch from 8554278 to 3b0d16f Compare September 3, 2024 18:41

update copywrite header and ci checks

7ca1fce

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

antoninbas reviewed Sep 6, 2024

View reviewed changes

update copywrite date

3465eea

Signed-off-by: Rupam-It <mannarupam3@gmail.com>

antoninbas approved these changes Sep 6, 2024

View reviewed changes

antoninbas merged commit 66c5b73 into antrea-io:main Sep 6, 2024
52 of 57 checks passed

Rupam-It deleted the add-node-latency-monitor-tests branch September 12, 2024 05:50


		ctx := context.Background()

		_, err := data.crdClient.StatsV1alpha1().NodeLatencyStats().Create(ctx, summary, v1.CreateOptions{})

	t.Logf("Invalid(negetive) RTT for peer %s on node %s", peerStat.NodeName, item.Name)
	t.Logf("Invalid RTT for peer %s reported by Node %s", peerStat.NodeName, item.Name)

		previousSendTime = targetStat.LastSendTime
		previousRecvTime = targetStat.LastRecvTime

Add e2e test for the NodeLatencyMonitor feature #6612

Add e2e test for the NodeLatencyMonitor feature #6612

Conversation

Rupam-It commented Aug 18, 2024

antoninbas left a comment

Choose a reason for hiding this comment

Rupam-It left a comment • edited Loading

Choose a reason for hiding this comment

antoninbas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rupam-It left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rupam-It left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rupam-It Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rupam-It left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rupam-It left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rupam-It left a comment

Choose a reason for hiding this comment

antoninbas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rupam-It left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rupam-It left a comment

Choose a reason for hiding this comment

antoninbas commented Sep 3, 2024

Rupam-It commented Sep 3, 2024

antoninbas commented Sep 4, 2024

Rupam-It commented Sep 5, 2024

Rupam-It commented Sep 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rupam-It commented Sep 6, 2024 • edited Loading

Rupam-It left a comment •

edited

Loading

Rupam-It Aug 28, 2024 •

edited

Loading

Rupam-It commented Sep 6, 2024 •

edited

Loading